Bug 1427176

Created attachment 1258110 [details]
log for qcow2 test on rhel7.4

Hi,

The test results posted in comment 2 don't seem to match the result from the original description (different tests are failing). Also, I am not sure which tests you are running exactly. Are those the upstream tests or the ones that are in RHEL's downstream qemu-kvm repository?

I'm asking because so far I only see 026 and 030 failing and I cannot see test 095 downstream.

Also, you have to make sure that not only QEMU_PROG is set but also QEMU_IMG_PROG (to qemu-img), QEMU_IO_PROG (to qemu-io), and QEMU_NBD_PROG (to qemu-nbd). The log from comment 2 looks like it's using the standard system versions of qemu-img and qemu-io there, and I'm not sure whether those are in the same version as the qemu you are trying to test.


Max

Created attachment 1262105 [details]
log for qcow2 test on rhel7.4 after applied patch

Created attachment 1262106 [details]
log for vmdk test on rhel7.4 after applied patch

Created attachment 1262107 [details]
log for vhdx test on rhel7.4 after applied patch

Thanks! Now I'm able to reproduce all of the qcow2 failures and working on fixing them.

Most of the vmdk and vhdx failures however are due to missing test images. Those are present in the git repository, just not in the source RPM. Since vmdk and vhdx are not exactly vital, I'd say that if you want to test them anyway you would have to use the git repository instead of the SRPM as the basis for testing.

If that does not fit into the test cycle very well, I think it would be fine to just omit vmdk and vhdx from testing (or anything that is not qcow2 or raw for that matter).

Max

*** Bug 1170963 has been marked as a duplicate of this bug. ***

Stefan made me reconsider my opinion from comment 10 that we could just omit vmdk and vhdx from testing. So if you need to run the tests from the SRPM and cannot run them from the git repository (or at least pull the test images from the repository), we will have to put the sample images into the SRPM as well.

So, would it be possible for you to run the tests from the repository instead of from the SRPM?

Max

Fix included in qemu-kvm-1.5.3-134.el7

Verify the issue with below packages and steps, all the cases for qcow2, raw, vhdx and vmdk are passed when run the test suit from the repository.

package version:
qemu-kvm-1.5.3-134.el7
kernel-3.10.0-619.el7

steps:
1. #git clone git://git.app.eng.bos.redhat.com/virt/rhel7/qemu-kvm.git
2. #cd /home/qemu-kvm
3. #git checkout qemu-kvm-1.5.3-134.el7
4. #cd tests/qemu-iotests
5. #export QEMU_PROG=/usr/libexec/qemu-kvm
6. #./check -qcow2(raw/vhdx/vmdk)

test results:
qcow2: Passed all 69 tests
raw: Passed all 20 tests
vhdx: Passed all 17 tests
vmdk: Passed all 26 tests

Hi Max,

Could you help to check the comment 13? Thanks in advance.

When ran the test suit from SRPM, the failure can still be reproduced.
vhdx:
Failures: 064 070
vmdk:
Failures: 059

Hi pingl,

Yes, as I wrote, those fail because the required sample images are missing from the SRPM. Miroslav Rezanina has told me that this will be no longer be an issue in 7.5, but for 7.4 we would require a specific fix (and just for 7.4).

So I'm not sure how to continue with this bug. From my point of view the most important fixes are merged now. Maybe Miroslav will write a patch to include the sample images in the SRPM; or I guess we can just keep the bug open until 7.5 but I'm not sure whether our process likes a bug that is neither NEW/ASSIGNED nor CLOSED to move from one release to another.

I have asked Miroslav to write such a patch if he thinks it's worth the effort so that we don't have to move this BZ to 7.5.


Max

(In reply to Max Reitz from comment #19)
> Hi pingl,
> 
> Yes, as I wrote, those fail because the required sample images are missing
> from the SRPM. Miroslav Rezanina has told me that this will be no longer be
> an issue in 7.5, but for 7.4 we would require a specific fix (and just for
> 7.4).
> 
> So I'm not sure how to continue with this bug. From my point of view the
> most important fixes are merged now. Maybe Miroslav will write a patch to
> include the sample images in the SRPM; or I guess we can just keep the bug
> open until 7.5 but I'm not sure whether our process likes a bug that is
> neither NEW/ASSIGNED nor CLOSED to move from one release to another.
> 
> I have asked Miroslav to write such a patch if he thinks it's worth the
> effort so that we don't have to move this BZ to 7.5.
> 
> 
> Max

Hi Max,

Many thanks for your info. I opened a new bug 1436280 to track the missing sample images, then we can set this bug as verified according to the comment 17.
Thanks again for your help.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1856