Bug 1427187

Created attachment 1260052 [details]
[PATCH] checkpoint: reactivate/update connections only if necessary on rollback

The attached patch avoids unnecessary operations (update and activate) on connections during a rollback.

/* ... or if the applied connection differs */
+    if (!nm_connection_compare (dev_checkpoint->applied_connection,
+                                nm_active_connection_get_applied_connection (active),
+                                NM_SETTING_COMPARE_FLAG_EXACT)) {

you could instead compare the version-id of the active-connection.
The difference is, your check tests whether the applied-connection differs,
the version-id tests whether the active-connection was deactivated/reapplied in the meantime. That latter test might make more sense in this context(??).

_LOGT ("rollback: connection is active");

these log statements could mention the connection they are talking about... otherwise, the logfile may contain several "connection is active" lines, but it's a bit confusing. 

indention in
+                        _LOGD ("rollback: updating connection %s",
+                                nm_setting


otherwise, lgtm

Fyi, Cockpit is now much better behaved: https://github.com/cockpit-project/cockpit/pull/5986

Created attachment 1260321 [details]
[PATCH v2] checkpoint: reactivate/update connections only if necessary on rollback

(In reply to Thomas Haller from comment #2)
> /* ... or if the applied connection differs */
> +    if (!nm_connection_compare (dev_checkpoint->applied_connection,
> +                                nm_active_connection_get_applied_connection
> (active),
> +                                NM_SETTING_COMPARE_FLAG_EXACT)) {
> 
> you could instead compare the version-id of the active-connection.
> The difference is, your check tests whether the applied-connection differs,
> the version-id tests whether the active-connection was deactivated/reapplied
> in the meantime. That latter test might make more sense in this context(??).

Both checks are fine, but comparing the version id is simpler and faster.


> _LOGT ("rollback: connection is active");
> 
> these log statements could mention the connection they are talking about...
> otherwise, the logfile may contain several "connection is active" lines, but
> it's a bit confusing. 
> 
> indention in
> +                        _LOGD ("rollback: updating connection %s",
> +                                nm_setting
> 

Fixed.

lgtm now

Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b9d11ffaa217c83d16e476523815478ce0b4f9a8

This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.