Bug 1427336

We could always require the package using the cammelCase form, but the directory tree should still be in lowercase. In this case, if I am mistaken, what could we do to improve gofed?

Hi Athos,

this is not gofed related. I choose github.com/spf13/jWalterWeatherman prefix willingly as it was a dependency of another project exactly in that form. First come, first served. However, I can duplicate the provided package in lowercase if it helps.

This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Hi Jan,

Duplicating the provides would help, but I believe that adding a link to the lowercase directory would also be needed:

src/github.com/spf13/hugo/helpers/content.go:31:2: cannot find package "github.com/spf13/jwalterweatherman" in any of:
	/builddir/build/BUILD/hugo-0.18.1/src/github.com/spf13/hugo/vendor/github.com/spf13/jwalterweatherman (vendor tree)
	/usr/lib/golang/src/github.com/spf13/jwalterweatherman (from $GOROOT)
	/builddir/build/BUILD/hugo-0.18.1/src/github.com/spf13/jwalterweatherman (from $GOPATH)
	/usr/share/gocode/src/github.com/spf13/jwalterweatherman

I do not understand how your packages

golang-github-spf13-cast
golang-github-spf13-viper

can find that path, since upstream imports it using the lowercase version of the jww. Was there any change from go 1.7.x to 1.8 or am I missing something?

I patched both cast and viper packages to use the cammelcase version.
Maybe it is time to change the prefix to lowercase.

Oh, I get it. Thank you!

I am building new version of the package with the lowercase provides right now.

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-38c0c02d40

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-38ff0f8d09

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceca9819c2

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-38ff0f8d09

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceca9819c2

golang-github-spf13-jWalterWeatherman-0-0.8.git33c24e7.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-38c0c02d40

Hello Jan,

Thank you for that!


golang-github-spf13-cast and golang-github-spf13-viper will also need to be rebuilt of any package depends on them. I already did it (removing the patches and changing requires for lowercase) in COPR and it builds cleanly. Would you like me to provide patches or get ACLs on those to help you with that?

Thank you again!

Both cast and viper updated. That would be great. How much packages would you be willing to help with? Some of them are more trickier than others. I am still extending the gofed to provide and run more analysis over Go projects. If you are interested in helping me with extending the tool, here are some issues [1]. Some of them are easy, some of them harder cause they require non trivial design and implementation of some other components, etc. I can tell you more if you have some spare time.

[1] https://github.com/gofed/gofed/issues

(In reply to Jan Chaloupka from comment #15)
> Both cast and viper updated. 

Thanks!

> That would be great. How much packages would
> you be willing to help with? Some of them are more trickier than others.

I do have some spare time to do that, I believe I would be able to handle a few.

> I
> am still extending the gofed to provide and run more analysis over Go
> projects. If you are interested in helping me with extending the tool, here
> are some issues [1]. Some of them are easy, some of them harder cause they
> require non trivial design and implementation of some other components, etc.
> I can tell you more if you have some spare time.

OK, I will take a look on the issues and then I may start a new thread on the golang mailing list so we can move this conversation there, is that ok?

> 
> [1] https://github.com/gofed/gofed/issues

> OK, I will take a look on the issues and then I may start a new thread on the
> golang mailing list so we can move this conversation there, is that ok?

Agree. Thanks.

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-78cd7e8542

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bc0b3b31d6

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c2082f195d

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-78cd7e8542

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c2082f195d

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bc0b3b31d6

jchaloup can you go ahead and push these updates to stable? that version worked for me in rawhide at least.

golang-github-spf13-jWalterWeatherman-0-0.9.git0efa520.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.