Bug 1427576
| Summary: | Review Request: golang-github-thejerf-suture - Supervisor trees for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jchaloup, package-review |
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-03-12 21:19:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1427634 | ||
|
Description
Fabio Valentini
2017-02-28 16:08:50 UTC
The spec file LGTM. License correct, no non-go files included. Approving. Just a nit that does not block the review request. Please, keep the %global commit fe1c0d795ff7a7e54fc54ef6afb36ee0adf0c276 macro in the spec file as gofed tooling use the macro to associate your spec file with the upstream repository. Thanks for the review! I'll put the %commit and %shortcommit things back before I import, I didn't know gofed uses it for statistics / analysis. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-thejerf-suture PSA: I am getting spurious test failures for about 10-15% of builds (the linked scratch build succeeded randomly, that's why I didn't catch the failures earlier). I have reported the problem upstream at [1] and will build the package once the issue is (hopefully) resolved. [1]: https://github.com/thejerf/suture/issues/20 That's quite common. In that case I just disable all the failing tests since usually you need the source code only which should work correctly with the a project the dependency is required in. Upstream fixed the broken test (yay!), so I am now submitting the new version (2.0.1) of the package with all tests enabled. golang-github-thejerf-suture-2.0.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3663a1a985 golang-github-thejerf-suture-2.0.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-77f53be72b golang-github-thejerf-suture-2.0.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-77f53be72b golang-github-thejerf-suture-2.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3663a1a985 golang-github-thejerf-suture-2.0.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. golang-github-thejerf-suture-2.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |