Bug 1428036

Summary:	Update rfc.sh to check/request issue # when a commit is an “rfc”
Product:	[Community] GlusterFS	Reporter:	Shyamsundar <srangana>
Component:	scripts	Assignee:	Shyamsundar <srangana>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-infra
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:46:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shyamsundar 2017-03-01 18:28:08 UTC

Gluster intends to move to github to track features being delivered against the code base.

Read the announcement here: http://lists.gluster.org/pipermail/gluster-devel/2017-February/052203.html

Specifics of the github process here: https://hackmd.io/s/BkgH8sdtg#

Towards the above the following change is requested:
----------------------------------------------------
Update rfc.sh to check/request issue # when a commit is an “rfc”:
    Change: https://github.com/gluster/glusterfs/blob/master/rfc.sh

    This is more a helping hand for the process, when a bug ID is not entered, it would be helpful to check if the commit message has a Fixes or Updates issue# comment, else prompt and edit the commit message accordingly

    The prompt can just be for an issue number, and not specifically "Updates" or "Fixes", just to keep it light. If the commit really is the last fix the submitter/reviewer should be able to handle the request for the appropriate keyword.

    For glusterfs-specs, we use git-review instead of rfc.sh, so a test needs to be enforced somewhere in that workflow for issue# presence (even reviewers can request for the same if it is missing), if possible lets automate it, else we will have to depend on reviewers

Comment 1 Nigel Babu 2017-03-03 04:42:01 UTC

This need not be an infra bug. This can be handled in the Gluster code base by modifying rfc.sh yourself. For git-review, you could write a pre-review hook that's shipping with glusterfs-specs that need to be copied to the hooks folder. Thoughts?

Comment 2 Shyamsundar 2017-03-03 14:09:44 UTC

(In reply to Nigel Babu from comment #1)
> This need not be an infra bug. This can be handled in the Gluster code base
> by modifying rfc.sh yourself. For git-review, you could write a pre-review
> hook that's shipping with glusterfs-specs that need to be copied to the
> hooks folder. Thoughts?

Yes, agree. Changing the component appropriately (which unfortunately goes to unclassified).

Comment 3 Worker Ant 2017-04-10 18:56:43 UTC

REVIEW: https://review.gluster.org/17032 (scripts: Update rfc.sh to prompt for a github issue on RFE commits) posted (#1) for review on master by Shyamsundar Ranganathan (srangana)

Comment 4 Worker Ant 2017-04-17 13:45:13 UTC

REVIEW: https://review.gluster.org/17032 (scripts: Update rfc.sh to prompt for a github issue on RFE commits) posted (#2) for review on master by Shyamsundar Ranganathan (srangana)

Comment 5 Worker Ant 2017-04-17 13:46:44 UTC

REVIEW: https://review.gluster.org/17032 (scripts: Update rfc.sh to prompt for a github issue on RFE commits) posted (#3) for review on master by Shyamsundar Ranganathan (srangana)

Comment 6 Worker Ant 2017-04-19 12:18:20 UTC

COMMIT: https://review.gluster.org/17032 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 2aeca0ef02733ebd9b7979e4c27585f3ebff53d7
Author: Shyam <srangana>
Date:   Mon Apr 10 11:36:17 2017 -0400

    scripts: Update rfc.sh to prompt for a github issue on RFE commits
    
    If a commit does not contain a bug check with the committer if
    this is an RFE (or such) and prompt to amend the commit with a
    github issue that relates to the change.
    
    Also, give some specifics on what string to add to refer to an
    issue.
    
    This change is meant to encourage committers to add github issues
    and hence will not enforce the same, IOW the check can be ignored
    and code can still be submitted. Reviewers would hence be
    responsible to check for the same.
    
    Change-Id: Id382247a787a96d55be6be554332a1b7ccde6bcd
    BUG: 1428036
    Signed-off-by: Shyam <srangana>
    Reviewed-on: https://review.gluster.org/17032
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 7 Shyamsundar 2017-05-30 18:46:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/