Bug 1428078

Summary:	Add TESTER_CFLAGS config option; use to fix proves tests in FB environment
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	atumball, bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-01 06:45:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vijay Bellur 2017-03-01 19:06:13 UTC

Add TESTER_CFLAGS config option; use to fix proves tests in FB environment

Summary:

When building tests using build_tester in FB environment, we need to
pass additional library flags. Plumb up to the --with-fbextras option.

Test Plan:

prove -f --timer ./tests/basic/gfapi/anonymous_fd.t

Reviewers:

Subscribers:

Tasks:

Blame Revision:

Change-Id: Ibd04851234f9367d6a3192ba2d4440ce3fa4a45b
Signed-off-by: Kevin Vigor <kvigor>
Reviewed-on: http://review.gluster.org/16204
NetBSD-regression: NetBSD Build System <jenkins.org>
Smoke: Gluster Build System <jenkins.org>
CentOS-regression: Gluster Build System <jenkins.org>
Reviewed-by: Shreyas Siravara <sshreyas>

Comment 1 Amar Tumballi 2018-10-12 07:52:43 UTC

The framework to pass extra flags to 'tests' makes sense for GlusterFS project! But having 'fbtirpc' in the flag in the patch may not be accepted in upstream! Will send the patch with a dummy flag with "-g -O0", lets see how it proceeds.

Comment 2 Yaniv Kaul 2019-07-01 06:07:24 UTC

Status?

Comment 3 Amar Tumballi 2019-07-01 06:45:14 UTC

We are not looking into these right now. We hope the latest branches are in good shape with respect to the test case spurious failures. Please upgrade to latest version and let us know how does this work.


For keeping track of this for future, marking the bugs as DEFERRED, so we can get back to this in future.