Bug 1428090

Summary:	cluster/afr: Hybrid mounts must honor _marked_ up/down states
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ravishankar
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-08 04:41:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vijay Bellur 2017-03-01 19:06:48 UTC

cluster/afr: Hybrid mounts must honor _marked_ up/down states

Summary:
- Qsorted latencies must also take into account that a host can be
  marked down yet still have a (slightly) better latency.  This can
  happen if max-replicas is reached, and there are multiple bricks which
  meet the halo threshold.  In such a case we must prefer the brick
  which is marked up albeit with a perhaps slightly higher latency.
  It's not worth doing any sort of swap in this case as it's going to be
  jarring to the cluster and introduce flapping behavior.

Test Plan: - Halo prove tests @ https://phabricator.fb.com/P56251020

Reviewers: sshreyas, kvigor

Reviewed By: kvigor

Blame Revision: Change-Id: I858bbf44638a4978093dc56d4a98c96be4f8b45e

Change-Id: Ie3b79700ec63398bc30e7bcf75fb05931dd5d0d0
FB-commit-id: deb2f35db6f8b979857b4e3779b2a41c59a2e416
Signed-off-by: Kevin Vigor <kvigor>
Reviewed-on: http://review.gluster.org/16307
CentOS-regression: Gluster Build System <jenkins.org>
NetBSD-regression: NetBSD Build System <jenkins.org>
Reviewed-by: Shreyas Siravara <sshreyas>
Smoke: Gluster Build System <jenkins.org>

Comment 1 Ravishankar N 2019-03-08 04:41:37 UTC

Basic halo replication functionality is present in master.There are no immediate plans for forward porting any pending halo related patches from the release-3.8-fb branch into master, hence closing the bug. Please feel free to re-open if there is a need for re-assessment.