Bug 1428510

Summary:	memory leak in features/locks xlator
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	locks	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1431591 1431592 (view as bug list)		Environment:
Last Closed:	2017-05-30 18:46:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1431591, 1431592

Description Xavi Hernandez 2017-03-02 17:35:24 UTC

Description of problem:

Bricks are using a lot of memory after accessing the volume through samba for a long period of time.

An state dump of one of the bricks shows this:

[features/locks.pacs-locks - usage-type gf_common_mt_strdup memusage]
size=1073020018
num_allocs=16027808
max_size=1073038724
max_num_allocs=16030143
total_allocs=279634993

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-03-03 09:45:07 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix memory leak of client_uid's) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Worker Ant 2017-03-03 10:09:48 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix memory leak of client_uid's) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 3 Worker Ant 2017-03-06 11:03:59 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix memory leak of client_uid's) posted (#3) for review on master by Xavier Hernandez (xhernandez)

Comment 4 Worker Ant 2017-03-07 09:23:06 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix memory leak of client_uid's) posted (#4) for review on master by Xavier Hernandez (xhernandez)

Comment 5 Worker Ant 2017-03-07 09:41:31 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix memory leak of client_uid's) posted (#5) for review on master by Xavier Hernandez (xhernandez)

Comment 6 Worker Ant 2017-03-09 08:32:22 UTC

REVIEW: https://review.gluster.org/16877 (features/locks: Fix leak of posix_lock_t's client_uid) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 7 Worker Ant 2017-03-09 08:33:29 UTC

REVIEW: https://review.gluster.org/16838 (features/locks: Fix leak of posix_lock_t's client_uid) posted (#6) for review on master by Xavier Hernandez (xhernandez)

Comment 8 Worker Ant 2017-03-12 00:52:21 UTC

COMMIT: https://review.gluster.org/16838 committed in master by Jeff Darcy (jdarcy) 
------
commit b3ac24cdd759fb4cd2946329860bcc004f736b23
Author: Xavier Hernandez <xhernandez>
Date:   Thu Mar 9 09:29:49 2017 +0100

    features/locks: Fix leak of posix_lock_t's client_uid
    
    Change-Id: I3bc14998ed6a8841f77a004c24a456331048a521
    BUG: 1428510
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: https://review.gluster.org/16838
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 9 Shyamsundar 2017-05-30 18:46:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/