Bug 1428517

Summary:	Review Request: golang-github-calmh-luhn - Luhn-mod-N implementation in Go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jchaloup, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:21:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427634

Description Fabio Valentini 2017-03-02 17:57:59 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-luhn.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-luhn-1.0.0-1.fc25.src.rpm

Description: Luhn-mod-N implementation in Go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139669

PS: The .spec file was generated by gofed, but modified to use the stable release (with tag v1.0.0) instead of git master. All tests pass on all arches, see the successful koji scratch build.

Comment 1 Jan Chaloupka 2017-03-03 12:44:20 UTC

I always keep the
Source0:        https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
in a form of
Source0:        https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz

You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit.

Not a blocker thought.

Comment 2 Fabio Valentini 2017-03-03 13:21:43 UTC

Thanks, I adapted the spec for your suggestion. The pkgdb request is sent.

Comment 3 Gwyn Ciesla 2017-03-06 14:23:54 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-calmh-luhn

Comment 4 Fedora Update System 2017-03-06 17:03:02 UTC

golang-github-calmh-luhn-1.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7586a875a5

Comment 5 Fedora Update System 2017-03-06 17:04:02 UTC

golang-github-calmh-luhn-1.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-aa0fdb29a6

Comment 6 Fedora Update System 2017-03-07 01:51:05 UTC

golang-github-calmh-luhn-1.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7586a875a5

Comment 7 Fedora Update System 2017-03-07 17:53:36 UTC

golang-github-calmh-luhn-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-aa0fdb29a6

Comment 8 Fedora Update System 2017-03-14 17:21:47 UTC

golang-github-calmh-luhn-1.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-15 17:52:34 UTC

golang-github-calmh-luhn-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.