Bug 1428526

Summary:	Review Request: golang-github-chmduquesne-rollinghash - Some rolling checksum implementations in go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jchaloup, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:22:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427634

Description Fabio Valentini 2017-03-02 18:27:59 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-chmduquesne-rollinghash.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc25.src.rpm

Description: Some rolling checksum implementations in go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139830


PS: The .spec file was generated by gofed, but the version was set to 2.0.2 to match the latest upstream release instead of 0. Still, git master is packaged since it seems to have important changes atop 2.0.2. All tests pass on all arches (see the successful koji scratch build).

Comment 1 Jan Chaloupka 2017-03-03 12:48:09 UTC

I always keep the
Source0:        https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
in a form of
Source0:        https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz

You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit.

Thought, not a blocker.

Comment 2 Fabio Valentini 2017-03-03 13:27:31 UTC

Thanks for the review, I just submitted the pkgdb request.

Comment 3 Gwyn Ciesla 2017-03-06 14:35:31 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-chmduquesne-rollinghash

Comment 4 Fedora Update System 2017-03-06 17:10:37 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5d1a801cbc

Comment 5 Fedora Update System 2017-03-06 17:11:23 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-55838daa1b

Comment 6 Fedora Update System 2017-03-07 01:51:13 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5d1a801cbc

Comment 7 Fedora Update System 2017-03-07 17:53:44 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-55838daa1b

Comment 8 Fedora Update System 2017-03-14 17:22:00 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-15 17:52:42 UTC

golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.