Bug 1428528

Summary:	Review Request: golang-github-gobwas-glob - Globbing library for Go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jchaloup, mgoodwin, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:22:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427634

Description Fabio Valentini 2017-03-02 18:43:40 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-gobwas-glob.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-gobwas-glob-0.2.2-1.fc25.src.rpm

Description: Globbing library for Go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139879


PS: The .spec file was generated by gofed, but modified to use the latest stable release (since upstream has releases). The %commit variable has been modified to point to the correct commit hash. All tests pass on all arches (see the successful koji scratch build).

Comment 1 Jan Chaloupka 2017-03-03 12:49:49 UTC

I always keep the
Source0:        https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
in a form of
Source0:        https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz

You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit.

Thought, not a blocker.

Comment 2 Fabio Valentini 2017-03-03 13:37:53 UTC

Thanks for the review, I adapted the spec for your suggestions. I've just sent the pkgdb request.

Comment 3 Gwyn Ciesla 2017-03-06 14:37:56 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-gobwas-glob

Comment 4 Fedora Update System 2017-03-06 17:17:19 UTC

golang-github-gobwas-glob-0.2.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-70269a915d

Comment 5 Fedora Update System 2017-03-06 17:18:14 UTC

golang-github-gobwas-glob-0.2.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d431eca584

Comment 6 Fedora Update System 2017-03-07 01:51:19 UTC

golang-github-gobwas-glob-0.2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-70269a915d

Comment 7 Fedora Update System 2017-03-07 17:53:49 UTC

golang-github-gobwas-glob-0.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d431eca584

Comment 8 Fedora Update System 2017-03-14 17:22:15 UTC

golang-github-gobwas-glob-0.2.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-15 17:52:47 UTC

golang-github-gobwas-glob-0.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Mark Goodwin 2019-04-30 01:55:03 UTC

*** Bug 1704506 has been marked as a duplicate of this bug. ***