Bug 1428691

Summary:	Review Request: perl-Email-Stuffer - More casual approach to creating and sending emails
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Email-Stuffer-0.014-1.fc27 perl-Email-Stuffer-0.014-1.fc26	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:21:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jitka Plesnikova 2017-03-03 07:23:38 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Email-Stuffer/perl-Email-Stuffer.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Email-Stuffer/perl-Email-Stuffer-0.014-1.fc27.src.rpm

Description:
Email::Stuffer is a fairly casual module used to stuff things into an email
and send them. It is a high-level module designed for ease of use when
doing a very specific common task, but implemented on top of the light and
tolerable Email:: modules.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-03-03 08:04:27 UTC

URL and Source0 addresses are Ok.
Source archive (SHA-256: 94e572ffdad457452c0ae8f33c10120c044deb711091c27b2077dc3b19a8b67e) is original. Ok.
Summary verified from lib/Email/Stuffer.pm. Ok.

TODO: I found the "Email:: emails" quite confusing. Simply removing the "Email::" word makes the summary better.

Description verified from lib/Email/Stuffer.pm. Ok.
License verified from lib/Email/Stuffer.pm, LICENSE, README. Ok.
No XS code, noarch BuildArch is Ok.
CPAN::Meta and CPAN::Meta::Prereqs are not helpful. Ok
All tests pass. Ok.

$ rpmlint perl-Email-Stuffer.spec ../SRPMS/perl-Email-Stuffer-0.014-1.fc27.src.rpm ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Mar  3 08:59 /usr/share/doc/perl-Email-Stuffer
-rw-r--r--    1 root    root                     2315 May  1  2016 /usr/share/doc/perl-Email-Stuffer/Changes
-rw-r--r--    1 root    root                      418 May  1  2016 /usr/share/doc/perl-Email-Stuffer/README
drwxr-xr-x    2 root    root                        0 Mar  3 08:59 /usr/share/licenses/perl-Email-Stuffer
-rw-r--r--    1 root    root                    18406 May  1  2016 /usr/share/licenses/perl-Email-Stuffer/LICENSE
-rw-r--r--    1 root    root                     5350 Mar  3 08:59 /usr/share/man/man3/Email::Stuffer.3pm.gz
drwxr-xr-x    2 root    root                        0 Mar  3 08:59 /usr/share/perl5/vendor_perl/Email
-rw-r--r--    1 root    root                    28456 May  1  2016 /usr/share/perl5/vendor_perl/Email/Stuffer.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.5.0
      1 perl(Carp)
      1 perl(Email::MIME) >= 1.920
      1 perl(Email::MIME::Creator)
      1 perl(Email::Sender::Simple)
      1 perl(File::Basename)
      1 perl(Module::Runtime)
      1 perl(Params::Util) >= 1.05
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(Email::Stuffer) = 0.014
      1 perl-Email-Stuffer = 0.014-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=18150839). Ok.

Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-03-06 14:19:01 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Email-Stuffer

Comment 3 Jitka Plesnikova 2017-03-06 15:25:13 UTC

Thank you for the review and the repository.

Comment 4 Fedora Update System 2017-03-06 15:33:00 UTC

perl-Email-Stuffer-0.014-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-be1ff5dc80

Comment 5 Fedora Update System 2017-03-07 01:50:52 UTC

perl-Email-Stuffer-0.014-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-be1ff5dc80

Comment 6 Fedora Update System 2017-03-14 17:21:24 UTC

perl-Email-Stuffer-0.014-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.