Bug 1428739

Summary:	Fix crash in dht resulting from tests/features/nuke.t
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	distribute	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1428743 (view as bug list)		Environment:
Last Closed:	2017-04-05 00:01:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1428743

Description Krutika Dhananjay 2017-03-03 09:37:06 UTC

Description of problem:

My patch at https://review.gluster.org/16419 is resulting in core dumps everytime I run tests/features/nuke.t.

Turns out dht, upon successfully "nuking" a directory, which was initiated through a setxattr, unwinds the operation with rmdir fop signature, resulting in readdir-ahead casting a struct iatt (preparent) to dict_t, leading to a crash.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-03-03 09:42:08 UTC

REVIEW: https://review.gluster.org/16836 (cluster/dht: Fix crash in "nuke-dir" feature) posted (#1) for review on release-3.10 by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2017-03-04 19:00:50 UTC

COMMIT: https://review.gluster.org/16836 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 4713b9a74879ecc2b3d5c96987609c09497bd005
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Mar 2 15:27:54 2017 +0530

    cluster/dht: Fix crash in "nuke-dir" feature
    
            Backport of: https://review.gluster.org/16829
    
    My patch at https://review.gluster.org/16419 is resulting
    in core dumps everytime I run tests/features/nuke.t.
    
    Turns out dht, upon successfully "nuking" a directory,
    which was initiated through a setxattr, unwinds the operation
    with rmdir fop signature, resulting in readdir-ahead casting
    a struct iatt (preparent) to dict_t, leading to a crash.
    
    Change-Id: I480f80170c31a6da3ff7809852449e6f44f7d047
    BUG: 1428739
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: https://review.gluster.org/16836
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Shyamsundar 2017-04-05 00:01:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.1, please open a new bug report.

glusterfs-3.10.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-April/030494.html
[2] https://www.gluster.org/pipermail/gluster-users/