Bug 1428926
| Summary: | Review Request: php-justinrainbow-json-schema5 - A library to validate a json schema | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Randy Barlow <randy> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, randy | ||||
| Target Milestone: | --- | Flags: | randy:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-03-31 23:47:50 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2017-03-03 15:53:56 UTC
Created attachment 1265193 [details]
review.txt
Suggestions, at your option:
* You can drop the rm -rf %{buildroot} in the install section.
fedora-review put this in the MUST section, but I disagree so I am
willing to pass as-is.
* You can drop the %defattr statement in the files section.
* You can drop the BuildRoot: line.
* You can delete the %clean section.
Thanks for the review (In reply to Randy Barlow from comment #1) > Created attachment 1265193 [details] > review.txt > > Suggestions, at your option: > > * You can drop the rm -rf %{buildroot} in the install section. > fedora-review put this in the MUST section, but I disagree so I am > willing to pass as-is. > * You can drop the %defattr statement in the files section. > * You can drop the BuildRoot: line. > * You can delete the %clean section. Yes, I usually clean those during Fedora import (and will be able to totally clean them in my repo in ~1 week \o/) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-justinrainbow-json-schema5 php-justinrainbow-json-schema5-5.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-560f805a30 php-justinrainbow-json-schema5-5.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b442ce6cb php-justinrainbow-json-schema5-5.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4534b24bc7 php-justinrainbow-json-schema5-5.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae1f436ff php-justinrainbow-json-schema5-5.2.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae1f436ff php-justinrainbow-json-schema5-5.2.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4534b24bc7 php-justinrainbow-json-schema5-5.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b442ce6cb php-justinrainbow-json-schema5-5.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-560f805a30 php-justinrainbow-json-schema5-5.2.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. php-justinrainbow-json-schema5-5.2.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. php-justinrainbow-json-schema5-5.2.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. php-justinrainbow-json-schema5-5.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |