Bug 1429506

Also, could OVMF be moved into a more "normal" repository to allow a quick yum install?

AFAIK this should all have been fixed in RHEL 7.3.

Anyway, I need to know:

 - precise version of virt-v2v
 - precise version of OVMF

and please attach the full log when you run the virt-v2v conversion
with the -v and -x options.

Hi Richard,

Sorry, I don't think I've been clear. The conversion starts, runs but then errors at the very end, several hours after starting, with the error in the original bug.

Better would be for virt-p2v to that OVMF is actually installed (it wasn't) before starting the conversion process, especially as the UEFI warning gets printed at the beginning.

E.g

Start conversion -> Check this is a UEFI guest = true -> Check that conversion server has OVMF installed -> true=proceed or false=exit with error

Does that make sense?

Or just make OVMF a dependency of virt-v2v package?

I'm still going to need all the information requested in comment 3 in order
to make any progress on diagnosing this.

(In reply to Christopher Brown from comment #5)
> Or just make OVMF a dependency of virt-v2v package?

OVMF is not a dependency because it isn't (or wasn't) in
the main repos, but that's a separate issue in any case.

Patch posted to detect OVMF presence earlier in the conversion process
for -o local:

https://www.redhat.com/archives/libguestfs/2017-March/msg00093.html

Wow, that was quick, thanks Richard!

Feel free to close this bug, I know to install the package in the meantime.

Let's leave the bug open to track inclusion of the patch.

Fixed in upstream commit a05e0fc0e8ffa2638e66ed1d71d41c470eadc4d7

Verify this bug with below builds:
virt-v2v-1.36.2-1.el7.x86_64
libguestfs-1.36.2-1.el7.x86_64
libvirt-3.1.0-2.el7.x86_64
qemu-kvm-rhev-2.8.0-6.el7.x86_64

Steps:
1:Make sure there is no OVMF package installed.
# rpm -qa | grep OVMF
None

2:Convert a uefi guest from vmware to libvirt
#  virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 rhel73-efi -of qcow2 --password-file /tmp/passwd -on test
[   0.0] Opening the source -i libvirt -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 rhel73-efi
[   1.1] Creating an overlay to protect the source from being modified
[   1.7] Initializing the target -o libvirt -os default
[   1.7] Opening the overlay
[  14.2] Inspecting the overlay
[  58.2] Checking for sufficient free disk space in the guest
[  58.2] Estimating space required on target for each disk
[  58.2] Converting Red Hat Enterprise Linux Server 7.2 (Maipo) to run on KVM
virt-v2v: This guest has virtio drivers installed.
[ 471.4] Mapping filesystem data to avoid copying unused and blank areas
virt-v2v: warning: fstrim on guest filesystem /dev/sda1 failed.  Usually 
you can ignore this message.  To find out more read "Trimming" in 
virt-v2v(1).

Original message: fstrim: fstrim: /sysroot/: the discard operation is not 
supported
[ 472.9] Closing the overlay
[ 472.9] Checking if the guest needs BIOS or UEFI to boot
virt-v2v: error: cannot find firmware for UEFI guests.

You probably need to install OVMF, or AAVMF (if using aarch64)

If reporting bugs, run virt-v2v with debugging enabled and include the 
complete output:


  virt-v2v -v -x [...]

Result:The conversion is report OVMF error at the end.
Addition:
When i using the below command ,it also has the problem.
#  virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 rhel73-efi -of qcow2 --password-file /tmp/passwd -on test -o local -os /var/tmp


Hi,rjones,from the patch,we expect to detect OVMF presence earlier in the conversion process. But i think the patch not works better.

(In reply to kuwei from comment #12)
> 2:Convert a uefi guest from vmware to libvirt
> #  virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1
> rhel73-efi -of qcow2 --password-file /tmp/passwd -on test
> [   0.0] Opening the source -i libvirt -ic
> vpx://root.75.182/data/10.73.3.19/?no_verify=1 rhel73-efi
> [   1.1] Creating an overlay to protect the source from being modified
> [   1.7] Initializing the target -o libvirt -os default
> [   1.7] Opening the overlay
> [  14.2] Inspecting the overlay
> [  58.2] Checking for sufficient free disk space in the guest
> [  58.2] Estimating space required on target for each disk
> [  58.2] Converting Red Hat Enterprise Linux Server 7.2 (Maipo) to run on KVM
> virt-v2v: This guest has virtio drivers installed.
> [ 471.4] Mapping filesystem data to avoid copying unused and blank areas
> virt-v2v: warning: fstrim on guest filesystem /dev/sda1 failed.  Usually 
> you can ignore this message.  To find out more read "Trimming" in 
> virt-v2v(1).
> 
> Original message: fstrim: fstrim: /sysroot/: the discard operation is not 
> supported
> [ 472.9] Closing the overlay
> [ 472.9] Checking if the guest needs BIOS or UEFI to boot
> virt-v2v: error: cannot find firmware for UEFI guests.
> 
> You probably need to install OVMF, or AAVMF (if using aarch64)
> 
> If reporting bugs, run virt-v2v with debugging enabled and include the 
> complete output:
> 
> 
>   virt-v2v -v -x [...]
> 
> Result:The conversion is report OVMF error at the end.
> Addition:
> When i using the below command ,it also has the problem.
> #  virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1
> rhel73-efi -of qcow2 --password-file /tmp/passwd -on test -o local -os
> /var/tmp
> 
> Hi,rjones,from the patch,we expect to detect OVMF presence earlier in the
> conversion process. But i think the patch not works better.

The fix of this bug affects only the -o local mode, -o libvirt (which is what the above run say) behaves the same.  Also, the check in both cases is not at the end of the conversion, but before the actual copying of the data (which is the most expensive part).

verify the bug with below builds again:
virt-v2v-1.36.2-2.el7.x86_64
libguestfs-1.36.2-2.el7.x86_64

From the bug Bug 1429643 - virt-v2v should depend on OVMF/AAVMF,we will see virt-v2v has depended on OVMF,so I think the bug has fixed,move the bug to VERIFIED

Thanks, lgtm, feel free to close.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2023