Bug 1429542

Summary: tripwire cron.daily e-mail address check fails
Product: [Fedora] Fedora EPEL Reporter: David Sommerseth <dazo>
Component: tripwireAssignee: Moez Roy <moez.roy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel7CC: didier.fabert, moez.roy, rebus, smparrish
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tripwire-2.4.3.4-1.fc24 tripwire-2.4.3.4-1.fc25 tripwire-2.4.3.4-1.el6 tripwire-2.4.3.4-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-30 00:21:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Sommerseth 2017-03-06 14:54:21 UTC
Description of problem:
The updated /etc/cron.daily/tripwire-check file in tripwire-2.4.3.2-3.el7.x86_64 fails extracting the e-mail address from twadmin.

The current sed regexp matches for "GLOBALEMAIL *=".  This will always fail if the white-spacing contains tabs.

# /usr/sbin/twadmin -m f | grep GLOBALEMAIL | hexdump -C
00000000  47 4c 4f 42 41 4c 45 4d  41 49 4c 09 20 20 20 20  |GLOBALEMAIL.    |
00000010  20 20 20 3d 72 6f 6f 74  40 65 78 61 6d 70 6c 65  |   =root@example|
00000020  2e 6f 72 67 0a                                    |.org.|
00000025

Notice the 0x09 right after the letter 'L'.

It would be better to match on non-word characters in this case.

# /usr/sbin/twadmin -m f | sed -n 's/^GLOBALEMAIL\W*=//p'
root


Version-Release number of selected component (if applicable):
tripwire-2.4.3.2-3.el7.x86_64

How reproducible:
Always


Actual results:
No e-mail address is extracted, thus no tripwire e-mail is sent to the tripwire configured e-mail address.

Expected results:
Respect the GLOBALEMAIL setting and send e-mails to this address, regardless if space or tabs are used.

Comment 1 Didier Fabert (tartare) 2017-03-10 11:55:49 UTC
Hi David,

Upstream has just release a new version and this bug will be removed on the next package release.

Best regards

Comment 2 Fedora Update System 2017-03-16 08:23:44 UTC
tripwire-2.4.3.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-942de8c23d

Comment 3 Fedora Update System 2017-03-16 08:24:17 UTC
tripwire-2.4.3.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9e57ad4e5

Comment 4 Fedora Update System 2017-03-16 23:20:39 UTC
tripwire-2.4.3.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-942de8c23d

Comment 5 Fedora Update System 2017-03-16 23:23:01 UTC
tripwire-2.4.3.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9e57ad4e5

Comment 6 Fedora Update System 2017-03-21 22:11:23 UTC
tripwire-2.4.3.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4503cb15e3

Comment 7 Fedora Update System 2017-03-21 22:11:56 UTC
tripwire-2.4.3.4-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9067ed16ad

Comment 8 David Sommerseth 2017-03-21 22:57:18 UTC
This update does NOT fix this issue on EPEL-7.

# grep tripwire /var/log/yum.log
Mar 05 06:37:37 Updated: tripwire.x86_64 2.4.3.2-3.el7
Mar 20 03:18:20 Updated: tripwire.x86_64 2.4.3.3-1.el7

After this update, I had to fix /etc/cron.daily/tripwire-check again to make it behave properly.

Comment 9 David Sommerseth 2017-03-21 23:06:06 UTC
Sorry!  I now spotted that the latest update sent to epel-testing was not the one I updated to.  Please disregard my comment #8 for now.  I have installed the proper version (tripwire-2.4.3.4-1.el7.x86_64) directly from Koji and will know in a few hours how this goes.

Comment 10 Didier Fabert (tartare) 2017-03-22 07:12:30 UTC
You are faster than mirror sync :-)

Comment 11 David Sommerseth 2017-03-22 12:46:16 UTC
Just wanted to confirm that tripwire-2.4.3.4-1.el7.x86_64 resolves this issue.

Comment 12 Fedora Update System 2017-03-23 01:49:25 UTC
tripwire-2.4.3.4-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9067ed16ad

Comment 13 Fedora Update System 2017-03-23 01:50:02 UTC
tripwire-2.4.3.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4503cb15e3

Comment 14 Fedora Update System 2017-03-30 00:21:31 UTC
tripwire-2.4.3.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-03-30 01:19:56 UTC
tripwire-2.4.3.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-04-06 23:46:45 UTC
tripwire-2.4.3.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2017-04-06 23:48:59 UTC
tripwire-2.4.3.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.