Bug 1429773

Summary:	disallow increasing replica count for arbiter volumes
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	arbiter	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	amukherj, bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1429200	Environment:
Last Closed:	2017-04-05 00:01:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1429200
Bug Blocks:

Description Ravishankar N 2017-03-07 04:20:55 UTC

+++ This bug was initially created as a clone of Bug #1429200 +++

Problem: add-brick command to increase replica count in an arbiter
    volume succeeds, causing undesirable effects like the 4th brick being
    loaded with the arbiter xlator, the 3rd one losing the arbiter xlator
    (when the brick process is restarted), arbitration logic in afr going
    for a toss etc.

    Fix: Arbiter configuration should always be a replica 3 volume (of
    which 3rd brick is arbiter). Hence disallow increasing replica count for
    arbiter volume configurations.

--- Additional comment from Worker Ant on 2017-03-05 10:49:52 EST ---

REVIEW: https://review.gluster.org/16845 (glusterd: disallow increasing replica count for arbiter volumes) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-03-06 00:59:50 EST ---

REVIEW: https://review.gluster.org/16845 (glusterd: disallow increasing replica count for arbiter volumes) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-03-06 08:26:57 EST ---

COMMIT: https://review.gluster.org/16845 committed in master by Atin Mukherjee (amukherj) 
------
commit b7ba77ab3ffb641d06223f7af5145d3d670b032a
Author: Ravishankar N <ravishankar>
Date:   Mon Feb 27 13:51:09 2017 +0530

    glusterd: disallow increasing replica count for arbiter volumes
    
    Problem: add-brick command to increase replica count in an arbiter
    volume succeeds, causing undesirable effects like the 4th brick being
    loaded with the arbiter xlator, the 3rd one losing the arbiter xlator
    (when the brick process is restarted), arbitration logic in afr going
    for a toss etc.
    
    Fix: Arbiter configuration should always be a replica 3 volume (of
    which 3rd brick is arbiter). Hence disallow increasing replica count for
    arbiter volume configurations.
    
    Change-Id: I9fe4edac880d0f711e6d44324ad5562974e53e51
    BUG: 1429200
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/16845
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Worker Ant 2017-03-07 04:23:17 UTC

REVIEW: https://review.gluster.org/16863 (glusterd: disallow increasing replica count for arbiter volumes) posted (#1) for review on release-3.10 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-03-07 13:54:22 UTC

COMMIT: https://review.gluster.org/16863 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 0c05761bcffaddaadfdd9f954609a9323ce87b24
Author: Ravishankar N <ravishankar>
Date:   Mon Feb 27 13:51:09 2017 +0530

    glusterd: disallow increasing replica count for arbiter volumes
    
    Problem: add-brick command to increase replica count in an arbiter
    volume succeeds, causing undesirable effects like the 4th brick being
    loaded with the arbiter xlator, the 3rd one losing the arbiter xlator
    (when the brick process is restarted), arbitration logic in afr going
    for a toss etc.
    
    Fix: Arbiter configuration should always be a replica 3 volume (of
    which 3rd brick is arbiter). Hence disallow increasing replica count for
    arbiter volume configurations.
    
    > Reviewed-on: https://review.gluster.org/16845
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    (cherry picked from commit b7ba77ab3ffb641d06223f7af5145d3d670b032a)
    
    Change-Id: I9fe4edac880d0f711e6d44324ad5562974e53e51
    BUG: 1429773
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/16863
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-04-05 00:01:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.1, please open a new bug report.

glusterfs-3.10.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-April/030494.html
[2] https://www.gluster.org/pipermail/gluster-users/