Description of problem:
We have added a button to hot add a hard disk to a VM. The action works correctly and the hard disk is added with the specified size. The problem is that it is only added as thick provisioned and we would like it to be thin.
The provider we are using is VMware. We have a method in the automate domain that will hot add a disk to VMware VM. We do not know how to specify how to add thin provision disk as it always defaults as thick.
# Get vm object
vm = $evm.root['vm']
##raise "Missing $evm.root['vm'] object" unless vm
##$evm.log(:info, "evm attributes:#{$evm.root.attributes.inspect}")
$evm.log("info", "dialog $evm.root['dialog_disk_size1' ")
size = $evm.root['dialog_disk_size1'].to_i
# Get the size for the new disk from the root object
##size = $evm.root['size'].to_i
$evm.log("info", "Detected size:<#{size}>")
# Add disk to a VM
if size.zero?
$evm.log("error", "Size:<#{size}> invalid")
else
$evm.log("info", "Creating a new #{size}GB disk on Storage:<#{vm.storage_name}>")
## vm.add_disk("[#{vm.storage_name}]", size * 1024, :sync => true)
## vm.add_disk("[#{vm.storage_name}]", size * 1024, {:sync => true, :thin_provisioned => true})
vm.add_disk("[#{vm.storage_name}]", size * 1024, :thin_provisioned => true)
end
Version-Release number of selected component (if applicable):
5.7
How reproducible:
Always
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
I have found these 2 documents concerning thin provisioning:
https://github.com/ManageIQ/manageiq/issues/12488https://github.com/ManageIQ/manageiq/pull/1758/files
Lucy, this change should be the same as what was added for RHV here: miq_ae_service_manageiq-providers-redhat-infra_manager-vm.rb
But needs to be applied to the VMware caller:
miq_ae_service_manageiq-providers-vmware-infra_manager-vm.rb
Description of problem: We have added a button to hot add a hard disk to a VM. The action works correctly and the hard disk is added with the specified size. The problem is that it is only added as thick provisioned and we would like it to be thin. The provider we are using is VMware. We have a method in the automate domain that will hot add a disk to VMware VM. We do not know how to specify how to add thin provision disk as it always defaults as thick. # Get vm object vm = $evm.root['vm'] ##raise "Missing $evm.root['vm'] object" unless vm ##$evm.log(:info, "evm attributes:#{$evm.root.attributes.inspect}") $evm.log("info", "dialog $evm.root['dialog_disk_size1' ") size = $evm.root['dialog_disk_size1'].to_i # Get the size for the new disk from the root object ##size = $evm.root['size'].to_i $evm.log("info", "Detected size:<#{size}>") # Add disk to a VM if size.zero? $evm.log("error", "Size:<#{size}> invalid") else $evm.log("info", "Creating a new #{size}GB disk on Storage:<#{vm.storage_name}>") ## vm.add_disk("[#{vm.storage_name}]", size * 1024, :sync => true) ## vm.add_disk("[#{vm.storage_name}]", size * 1024, {:sync => true, :thin_provisioned => true}) vm.add_disk("[#{vm.storage_name}]", size * 1024, :thin_provisioned => true) end Version-Release number of selected component (if applicable): 5.7 How reproducible: Always Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: I have found these 2 documents concerning thin provisioning: https://github.com/ManageIQ/manageiq/issues/12488 https://github.com/ManageIQ/manageiq/pull/1758/files