Bug 1430688

Summary:	incorrectly updated graphics devices on old templates
Product:	[oVirt] ovirt-engine	Reporter:	Tomas Jelinek <tjelinek>
Component:	BLL.Virt	Assignee:	Martin Betak <mbetak>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.0	CC:	bugs, nsimsolo, sgratch, stirabos, tjelinek
Target Milestone:	ovirt-4.1.3	Flags:	rule-engine: ovirt-4.1? tjelinek: planning_ack? rule-engine: devel_ack+ mavital: testing_ack+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-06 13:57:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2017-03-09 10:18:29 UTC

Have a template which has this devices:

vnc           | graphics
cdrom         | disk
ich6          | sound
unix          | channel
memballoon    | balloon
virtio-serial | controller
bridge        | interface
disk          | disk
unix          | channel
spicevmc      | channel
usb           | controller
ide           | controller


There are two issues:

1: If the graphics is VNC but the display is not as one of the devices (old situation) the update VM does not add the display device properly.

2: The change from spice to vnc does not remove the spicevmc channel

Comment 1 Yaniv Kaul 2017-03-09 13:19:11 UTC

Severity?
Target milestone?

Comment 2 Martin Betak 2017-03-20 13:22:28 UTC

2. appears to have already been fixed by BZ#1430009

attempting to reproduce 1...

Comment 3 Sharon Gratch 2017-03-30 12:34:53 UTC

(In reply to Tomas Jelinek from comment #0)

> There are two issues:
> 
> 1: If the graphics is VNC but the display is not as one of the devices (old
> situation) the update VM does not add the display device properly.
>
It seems that BZ#1434161 already fixed that issue.

Comment 4 Sharon Gratch 2017-03-30 13:29:50 UTC

There is still a bug not solved by BZ#1434161 and I guess that's what Tomas meant: 
Edit a template that doesn't have a video device added to vm_devices and you only change the graphics type as follows:
(qxl, spice) to (qxl, vnc) 
or
(qxl, vnc) to (qxl, spice)

Comment 5 Martin Betak 2017-04-04 08:33:59 UTC

Yes, Sharon, you are right the 2) is not yet fixed. But the POST-ed patch (75050) should cover also those remaining cases.

Comment 6 Martin Betak 2017-04-04 11:00:56 UTC

Still pending fix for the spicevmc channels

Comment 7 Nisim Simsolo 2017-06-04 11:31:44 UTC

Verification builds:
ovirt-engine-4.1.3-0.1.el7
vdsm-4.19.16-1.el7ev.x86_64
qemu-kvm-rhev-2.6.0-28.el7_3.10.x86_64
libvirt-client-2.0.0-10.el7_3.9.x86_64