Bug 1431183
Summary: | [RFE] Gluster get state command should provide connected client related information | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Darshan <dnarayan> | |
Component: | glusterd | Assignee: | Samikshan Bairagya <sbairagy> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | mainline | CC: | amukherj, bugs, dnarayan | |
Target Milestone: | --- | Keywords: | Triaged | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.11.0 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1488020 (view as bug list) | Environment: | ||
Last Closed: | 2017-05-30 18:47:11 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1488020 |
Description
Darshan
2017-03-10 14:30:15 UTC
(In reply to Darshan from comment #0) > Description of problem: > Currently "gluster get-state" command does not give any client related > information. It should give information about the clients connected to a > particular volume(like things provided by "volume status clients" command), > along with other volume details. What other volume details are we looking for? Can you please be a little more specific on this? > > Version-Release number of selected component (if applicable): > 3.10 > > How reproducible: > > > Steps to Reproduce: > 1. > 2. > 3. > > Actual results: > > > Expected results: > > > Additional info: > If its very costly to provide this information please enhance gluster > get-state to take an option something like "--detail". When "--detail" is > provided get-state must provide all the details including the ones which are > costly to fetch. Without this option it should only give information which > are not costly. > > This is needed for tendrl project: > https://redhat.invisionapp.com/share/729GRP1W9#/screens/207638142 (In reply to Atin Mukherjee from comment #1) > (In reply to Darshan from comment #0) > > Description of problem: > > Currently "gluster get-state" command does not give any client related > > information. It should give information about the clients connected to a > > particular volume(like things provided by "volume status clients" command), > > along with other volume details. > > What other volume details are we looking for? Can you please be a little > more specific on this? Sorry for ambiguous statement. By "other volume details" I meant the details that is being already provided by the command. Have raised separate BZs for each specific requirement that is needed from the command. > > > > > Version-Release number of selected component (if applicable): > > 3.10 > > > > How reproducible: > > > > > > Steps to Reproduce: > > 1. > > 2. > > 3. > > > > Actual results: > > > > > > Expected results: > > > > > > Additional info: > > If its very costly to provide this information please enhance gluster > > get-state to take an option something like "--detail". When "--detail" is > > provided get-state must provide all the details including the ones which are > > costly to fetch. Without this option it should only give information which > > are not costly. > > > > This is needed for tendrl project: > > https://redhat.invisionapp.com/share/729GRP1W9#/screens/207638142 REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#1) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#2) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#3) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#4) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#5) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#6) for review on master by Samikshan Bairagya (samikshan) REVIEW: https://review.gluster.org/17003 (glusterd: Add client details to get-state output) posted (#7) for review on master by Atin Mukherjee (amukherj) COMMIT: https://review.gluster.org/17003 committed in master by Atin Mukherjee (amukherj) ------ commit b4beaa0505e8b23ac027fb6c995aa259c3f7550a Author: Samikshan Bairagya <samikshan> Date: Wed Apr 5 18:03:10 2017 +0530 glusterd: Add client details to get-state output This commit optionally adds client details corresponding to the locally running bricks to the get-state output. Since getting the client details involves sending RPC requests to the respective local bricks, this is a relatively more costly operation. These client details would be added to the get-state output only if the get-state command is invoked with the 'detail' option. This commit therefore also changes the get-state CLI usage. The modified usage is as follows: # gluster get-state [<daemon>] [[odir </path/to/output/dir/>] \ [file <filename>]] [detail] Change-Id: I42cd4ef160f9e96d55a08a10d32c8ba44e4cd3d8 BUG: 1431183 Signed-off-by: Samikshan Bairagya <samikshan> Reviewed-on: https://review.gluster.org/17003 NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/ |