Bug 1431199

Summary:	Request to automate closing github PRs
Product:	[Community] GlusterFS	Reporter:	Shyamsundar <srangana>
Component:	project-infrastructure	Assignee:	bugs <bugs>
Status:	CLOSED DEFERRED	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	atumball, bugs, gluster-infra, sankarshan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-27 01:22:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shyamsundar 2017-03-10 15:07:10 UTC

This request is discussed here: http://lists.gluster.org/pipermail/maintainers/2017-March/002325.html

We do not accept github PRs as our work flow is gerrit based.

To educate contributors, one of the things we could do is to put up a 
template as in [1] for the PULL_REQUEST_TEMPLATE. It will look like this 
[2] when users attempt to submit PRs.

An alternate idea suggested by Nigel was to accept PRs, but use a 
Jenkins job to auto close the same, with some generic (or very specific) 
instructions on how to submit it to our gerrit instance.

The advantage of the latter method is that we do not lose the code 
change suggested, and we can still evaluate the same and reach out to 
the contributor and also possibly get the change into our gerrit instance.

The latter approach looks good, and we would like to have this inplemented. This bug is being raised for the same.

Also, this is not an urgent requirement, this can happen in the next month or beyond, as this does not change anything major for us at the moment.

[1] PR template: 
https://review.gluster.org/#/c/16618/1/.github/PULL_REQUEST_TEMPLATE

[2] How a PR template appears to contributors: 
https://goo.gl/photos/xxc8j3myqzD9tME98

Comment 1 Nigel Babu 2017-05-21 03:47:38 UTC

Shyam, do we still want to do this?

Comment 2 Shyamsundar 2017-05-22 17:07:45 UTC

<added Amar>

I think this is still valid, we never added PULL_REQUEST_TEMPLATE, stating we will get this instead (as of the last conversation in the lists).

In the future, even if we do auto sync between PRs and gerrit, which I think may take time, we should possibly make this happen as well till then.

@Amar, thoughts?

Comment 3 Amar Tumballi 2017-05-23 05:30:26 UTC

This is still valid. Right now, we have around 13 PRs, for which I would manually recommend gerrit and close them in Github. But in general for future we need some automated way of 'posting' that message when the PR is generated.

If everyone is fine, I would do that using zapier, but message will be from my account  :-)