Bug 1431363 (php-google-auth)

Summary: Review Request: php-google-auth - Google Auth Library for PHP
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-12 14:52:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1386152, 1438295    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2017-03-11 16:09:24 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/53df993d19dd90d88677f0c568db09cf29e2432a/php-google-auth/php-google-auth.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-google-auth-0.11.1-1.fc25.src.rpm

Description:
This is Google's officially supported PHP client library for using OAuth 2.0
authorization and authentication with Google APIs.


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2017-03-12 06:05:35 UTC 
BTW, I just noticed (bug #1386152) you plan to create a php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ?
Comment 2 Shawn Iwinski 2017-03-12 21:18:48 UTC 
(In reply to Remi Collet from comment #1)
> BTW, I just noticed (bug #1386152) you plan to create a
> php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ?

I'm rethinking that comment... https://bugzilla.redhat.com/show_bug.cgi?id=1386152#c7
Comment 3 Remi Collet 2017-04-04 11:01:07 UTC 
Created attachment 1268608 [details]
phpci.log

phpCompatInfo version 5.0.6 DB version 1.19.0 built Mar 17 2017 06:44:54 CET static analyze results
Comment 4 Remi Collet 2017-04-04 11:01:36 UTC 
Created attachment 1268609 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1431363
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Comment 5 Remi Collet 2017-04-04 11:02:09 UTC 
[x]: Package complies to the Packaging Guidelines



=== APPROVED ===
Comment 6 Shawn Iwinski 2017-04-04 23:58:56 UTC 
THANKS for the review.  Pkgdb request submitted for rawhide and f26 (just like php-google-apiclient1).
Comment 7 Gwyn Ciesla 2017-04-05 02:03:10 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-google-auth
Comment 8 Fedora Update System 2017-04-08 15:07:01 UTC 
php-google-auth-0.11.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4a54a24fea
Comment 9 Fedora Update System 2017-04-09 05:54:22 UTC 
php-google-auth-0.11.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4a54a24fea
Comment 10 Fedora Update System 2017-04-12 14:52:45 UTC 
php-google-auth-0.11.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.