Bug 1431450
| Summary: | Review Request: impallari-raleway-fonts - Elegant sans-serif typeface family | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-09 16:44:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1512217 | ||
|
Description
Fabio Valentini
2017-03-12 16:59:22 UTC
Taking this review. Ping. > %global commit_date 161116
Please use the fuller, unambiguous date form (YYYYMMDD). I can't tell what this date actually is.
Spec URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.src.rpm Review notes:
[x] Package is named according to packaging guidelines for fonts
[x] fontconfig snippet looks fine
[x] No relevant rpmlint issues.
[!] Missing metainfo file for fonts to show up in software centers
* Please add an AppStream metainfo file for the font. As an example: http://pkgs.fedoraproject.org/cgit/rpms/aajohan-comfortaa-fonts.git/tree/aajohan-comfortaa.metainfo.xml
1) Added AppStream metadata file 2) Added validation check in %check Spec URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1.src.rpm Looks good to me now. PACKAGE APPROVED. Thanks for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/impallari-raleway-fonts impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37c547ee61 impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-41d13acccf impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-41d13acccf impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37c547ee61 impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |