Bug 1431528

Summary: Container Review Request: redis - Redis in-memory data structure store, used as database, cache and message broker
Product: [Fedora] Fedora Container Images Reporter: Honza Horak <hhorak>
Component: Container ReviewAssignee: Marek Skalický <mskalick>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 26CC: container-review, hhorak, mskalick, package-review
Target Milestone: ---Flags: mskalick: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-16 10:01:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1436796    

Description Honza Horak 2017-03-13 07:06:34 UTC 
Dockerfile URL: https://hhorak.fedorapeople.org/redis-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/redis-docker/

Description: Redis 3.2 available as docker container, is an advanced key-value store. It is often referred to as a data structure server since keys can contain strings, hashes, lists, sets and sorted sets. You can run atomic operations on these types, like appending to a string; incrementing the value in a hash; pushing to a list; computing set intersection, union and difference; or getting the member with highest ranking in a sorted set. In order to achieve its outstanding performance, Redis works with an in-memory dataset. Depending on your use case, you can persist it either by dumping the dataset to disk every once in a while, or by appending each command to a log.

Fedora Account System Username: hhorak
Comment 1 Marek Skalický 2017-03-29 07:47:32 UTC 
* Few labels are missing: [1]
BZComponent, RUN or Usage, Help

* Version label should be set to 0 [2]

[1] https://fedoraproject.org/wiki/Container:Guidelines#LABELS
[2] https://fedoraproject.org/wiki/Container:Guidelines#VERSIONING
Comment 2 Honza Horak 2017-04-07 13:34:35 UTC 
Thank you for the review, it's now fixed:
...
ENV NAME=redis \
    VERSION=0 \
    RELEASE=1 \
    ARCH=x86_64

LABEL BZComponent="$NAME" \
      Name="$FGC/$NAME" \
      Version="$VERSION" \
      Release="$RELEASE.$DISTTAG" \
      Architecture="$ARCH" \
      usage="docker run -d --name redis_database -p 6379:6379 f25/redis" \
      Help="help.1"
...

Dockerfile URL: https://hhorak.fedorapeople.org/redis-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/redis-docker/
Comment 3 Marek Skalický 2017-04-11 07:34:00 UTC 
Sorry for late answer. So review is now complete.
Comment 4 Gwyn Ciesla 2017-04-11 13:22:30 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/redis