Bug 1431592

Summary:	memory leak in features/locks xlator
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	locks	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.11	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1428510	Environment:
Last Closed:	2017-04-11 09:06:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1428510
Bug Blocks:	1431410

Description Xavi Hernandez 2017-03-13 11:46:28 UTC

+++ This bug was initially created as a clone of Bug #1428510 +++

Description of problem:

Bricks are using a lot of memory after accessing the volume through samba for a long period of time.

An state dump of one of the bricks shows this:

[features/locks.pacs-locks - usage-type gf_common_mt_strdup memusage]
size=1073020018
num_allocs=16027808
max_size=1073038724
max_num_allocs=16030143
total_allocs=279634993

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-03-13 11:52:51 UTC

REVIEW: https://review.gluster.org/16896 (features/locks: Fix leak of posix_lock_t's client_uid) posted (#1) for review on release-3.8 by Xavier Hernandez (xhernandez)

Comment 2 Worker Ant 2017-04-07 11:54:45 UTC

COMMIT: https://review.gluster.org/16896 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit ca58ac814e2d983f6ebdf532a40ae9d5a216226b
Author: Xavier Hernandez <xhernandez>
Date:   Thu Mar 9 09:29:49 2017 +0100

    features/locks: Fix leak of posix_lock_t's client_uid
    
    > Change-Id: I3bc14998ed6a8841f77a004c24a456331048a521
    > BUG: 1428510
    > Signed-off-by: Xavier Hernandez <xhernandez>
    > Reviewed-on: https://review.gluster.org/16838
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Amar Tumballi <amarts>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: I3bc14998ed6a8841f77a004c24a456331048a521
    BUG: 1431592
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: https://review.gluster.org/16896
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Niels de Vos 2017-04-11 09:06:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.11, please open a new bug report.

glusterfs-3.8.11 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/packaging/2017-April/000289.html
[2] https://www.gluster.org/pipermail/gluster-users/