Bug 1431688
| Summary: | service dialog can be submitted before entry point code on dynamic fields has completed execution | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Saif Ali <saali> | ||||
| Component: | Automate | Assignee: | eclarizi | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.7.0 | CC: | eclarizi, gblomqui, greartes, jhardy, mkanoor, myoder, obarenbo, rlsmith, simaishi, sshveta, tfitzger | ||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||
| Target Release: | cfme-future | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | service | ||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1439313 1439314 (view as bug list) | Environment: | |||||
| Last Closed: | 2018-08-07 14:31:53 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1439313, 1439314 | ||||||
| Attachments: |
|
||||||
|
Description
Saif Ali
2017-03-13 15:45:52 UTC
Can you confirm that this is in the OPs UI? Also, can you give me the exact set of steps you're using? I imported the given dialog and couldn't see anything that would've indicated the behavior you're seeing. I don't have all of the automate methods that are used by this dialog, but I tried an automate method with a "sleep 10" in it so that I could visibly see a fake "delay". The only thing I could think of is maybe someone typed in one of the fields that was triggering the auto-refresh and then before tabbing out of it or clicking off (which trigger the refresh), they clicked 'submit', but I tried this as well and it correctly makes the dynamic field update calls first, and then attempts to submit the dialog. Is there a specific catalog item setup that maybe I'm missing? New commit detected on ManageIQ/manageiq-ui-service/master: https://github.com/ManageIQ/manageiq-ui-self_service/commit/7abbefddabbe70335edc73e25d4d830dfe4cc32f commit 7abbefddabbe70335edc73e25d4d830dfe4cc32f Author: Erik Clarizio <eclarizi> AuthorDate: Fri Mar 31 08:29:15 2017 -0700 Commit: Erik Clarizio <eclarizi> CommitDate: Fri Mar 31 08:34:43 2017 -0700 Disable add to cart button when dynamic fields are processing https://bugzilla.redhat.com/show_bug.cgi?id=1431688 client/app/states/catalogs/details/details.html | 2 +- .../app/states/catalogs/details/details.state.js | 13 +++++ .../states/catalogs/details/details.state.spec.js | 68 +++++++++++++++++++++- 3 files changed, 79 insertions(+), 4 deletions(-) From a previous discussion, we determined this was an SUI issue. The fix I've implemented just makes it so that the "add to cart" button is disabled while the dynamic fields are still updating. Created attachment 1346087 [details]
add to shopping cart enabled while refresh is working
We shouldn't be able to add the catalog item to the shopping cart while it's being refreshed.
Not working in 5.9.0.4.20171024163837_ef71ea6
Add to shopping cart is enabled while refresh is working .
Screenshot attached.
Yeah the code got changed to use the new targeted auto refresh system and the new dialog-user ui-component and the part that was ensuring the "add to shopping cart" button gets disabled got lost in there somehow. We think issue has been fixed with latest PRs. Waiting for QE to validate. Works in master.20180525014609_98ef65d Hi Shveta, Can you test this on the latest 5.9.2.4? Thanks, Tina "Add to shopping cart" button is disabled while refresh is working . Verified in 5.10.0.3.20180705151325_ce4d2b5 Verified in 5.9.3.4.20180702181921_afd03d7 |