Bug 1431742

Summary: Review Request: perl-Config-INI-Reader-Ordered - INI file parser that returns sections in order
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Config-INI-Reader-Ordered-0.020-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-15 15:08:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1432106    

Description Petr Pisar 2017-03-13 16:45:29 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Config-INI-Reader-Ordered/perl-Config-INI-Reader-Ordered.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Config-INI-Reader-Ordered/perl-Config-INI-Reader-Ordered-0.020-1.fc27.src.rpm
Description:
Config::INI::Reader::Ordered is a subclass of Config::INI::Reader which
preserves section order.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-03-14 16:50:05 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Config-INI-Reader-Ordered-0.020-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Config::INI::Reader)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Config-INI-Reader-Ordered-0.020-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Config::INI::Reader::Ordered) = 0.020
      1 perl-Config-INI-Reader-Ordered = 0.020-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Config-INI-Reader-Ordered*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

FIX: Remove LICENSE from '%doc', it is already listed in '%license'

Please correct 'FIX' issue.

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2017-03-15 12:38:05 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Config-INI-Reader-Ordered
Comment 3 Petr Pisar 2017-03-15 15:08:37 UTC 
Thank you for the review and the repository. I removed the duplicated LICENSE file.