Bug 1431761
| Summary: | Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Athos Ribeiro <athoscribeiro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, morphis, package-review |
| Target Milestone: | --- | Flags: | athoscribeiro:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-21 14:27:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1427634 | ||
|
Description
Fabio Valentini
2017-03-13 17:17:18 UTC
*** Bug 1431054 has been marked as a duplicate of this bug. *** I've had a look at this as a new packager. Followed the review process as described in https://fedoraproject.org/wiki/Package_Review_Process Please don't consider my review as approval. Package was generated through gofed which makes the review process easier. - Conforms to packaging guidelines (gofed generated spec) - license correct and valid - only sources installed - fedora-review report doesn't show any failures, items marked as "need manual review" pass Hello Fabio, I am taking this review :) - The conditional block on line 130 seems to be duplicated. - There is no 1.1.0 version for this package. Latest git tag is 1.0.0. - Note that the X.Y format for the release tag is suggested for pre-releases, not post-releases. Also, the versioning guidelines were changed last month [1]. In particular, it seems that including the date the snapshot was taken is a must item (in this case, we should also update gofed). Other than that, the package looks good. [1] https://fedoraproject.org/wiki/Packaging:Versioning Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-AudriusButkevicius-cli.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26.src.rpm - You are right, Version 1.1.0 is plain wrong, it must be a typo or copy-paste-error. I've corrected it to 1.0.0. - I have removed the redundant %if-else statements. - I have included the commit date into the Release string as stated in the Guidelines for Snapshot versions (gofed should really be updated to reflect those changes, too!). Package approved Thanks for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-AudriusButkevicius-cli golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-067b202929 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4080d8884 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-de3fe47b79 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-de3fe47b79 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4080d8884 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-067b202929 golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |