Bug 1431763
| Summary: | Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Athos Ribeiro <athoscribeiro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, package-review |
| Target Milestone: | --- | Flags: | athoscribeiro:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-05-02 23:14:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1431759 | ||
| Bug Blocks: | 1427634 | ||
|
Description
Fabio Valentini
2017-03-13 17:18:01 UTC
koji scratch build, as all dependencies are available on rawhide now: https://koji.fedoraproject.org/koji/taskinfo?taskID=18679011 Hi Fabio, I am taking this one. - Conditional clauses on line 144 are duplicated. - The guidelines for post releases have changed [1], in special, the release tag for post release should not be in X.Y format (use just the X) and the date the snapshot was taken must be included there. - The test data could be included as a separate source file, but that's not a blocker here. [1] https://fedoraproject.org/wiki/Packaging:Versioning Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-golang.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26.src.rpm - Redundant conditional removed - Release: tag fixed - updated to newer snapshot For now I would rather not include another git repository snapshot tarball for the test data. Maybe I'll add it in the future, if there is demand for enabling the tests. Package looks good now! Approved Thanks for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-oschwald-geoip2-golang golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37 golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95 golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37 golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95 golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4a6754314 golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4a6754314 golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |