Bug 1431766

Summary: Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects
Product: [Fedora] Fedora Reporter: François Kooman <fkooman>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-24 17:50:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
phpci-src.log
none
review.txt none

Description François Kooman 2017-03-13 17:23:23 UTC
Spec URL: https://fkooman.fedorapeople.org/php-paragonie-constant-time-encoding/php-paragonie-constant-time-encoding.spec
SRPM URL: https://fkooman.fedorapeople.org/php-paragonie-constant-time-encoding/php-paragonie-constant-time-encoding-1.0.1-3.fc25.src.rpm
Description: 

Based on the constant-time base64 implementation made by Steve "Sc00bz" 
Thomas, this library aims to offer character encoding functions that do not 
leak information about what you are encoding/decoding via processor cache 
misses.

Fedora Account System Username: fkooman

Comment 1 Remi Collet 2017-03-15 13:19:12 UTC
Created attachment 1263336 [details]
phpci.log

     Note: phpCompatInfo version 5.0.4 DB version 1.18.0 built Feb 24 2017
     14:37:58 CET static analyze results

Comment 2 Remi Collet 2017-03-15 13:19:49 UTC
Created attachment 1263337 [details]
phpci-src.log

phpcompatinfo only on "src" tree

Comment 3 Remi Collet 2017-03-15 13:20:16 UTC
Created attachment 1263338 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1431766
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api

Comment 4 Remi Collet 2017-03-15 13:23:31 UTC
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/php/ParagonIE
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/php/ParagonIE

[!]: Requires correct, justified where necessary.
	BuilRequires: php-pcre is missing (see phpci.log
	paragonie/random_compat only need for test, no need to require it (see composer.json)


Tips:

%check
mkdir vendor
cat << 'EOF' | tee vendor/autoload.php
<?php
require_once '%{buildroot}%{_datadir}/php/%{composer_namespace}/autoload.php';
require_once '%{_datadir}/php/random_compat/autoload.php';
EOF
phpunit --no-coverage --verbose

Comment 6 Remi Collet 2017-03-15 15:08:47 UTC
+%dir %{_datadir}/php/ParagonIE 

[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/php/ParagonIE
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/php/ParagonIE

+BuildRequires:  php-pcre 
-Requires:   php-composer(paragonie/random_compat) 

[x]: Requires correct, justified where necessary.


No more blocker.

=== APPROVED ===

Comment 7 François Kooman 2017-03-15 15:13:06 UTC
Thanks again! Should I add you as comaintainer?

Comment 8 Remi Collet 2017-03-15 15:15:18 UTC
> Thanks again! Should I add you as comaintainer?

Not really needed (but you can), in all case, I will be able to change it using my provenpackager power if something need to be fixed.

Comment 9 Gwyn Ciesla 2017-03-15 16:24:26 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-paragonie-constant-time-encoding

Comment 10 Fedora Update System 2017-03-15 21:41:11 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4f8c3ca6b

Comment 11 Fedora Update System 2017-03-15 21:41:44 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bfb5f6f7f

Comment 12 Fedora Update System 2017-03-15 21:42:15 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20426f634

Comment 13 Fedora Update System 2017-03-15 21:42:44 UTC
php-paragonie-constant-time-encoding-1.0.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-626ff244d9

Comment 14 Fedora Update System 2017-03-16 00:51:34 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4f8c3ca6b

Comment 15 Fedora Update System 2017-03-16 22:49:58 UTC
php-paragonie-constant-time-encoding-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-626ff244d9

Comment 16 Fedora Update System 2017-03-16 23:20:26 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20426f634

Comment 17 Fedora Update System 2017-03-16 23:22:46 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bfb5f6f7f

Comment 18 Fedora Update System 2017-03-24 17:50:44 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2017-03-24 18:55:31 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2017-04-01 15:48:55 UTC
php-paragonie-constant-time-encoding-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2017-04-01 17:08:42 UTC
php-paragonie-constant-time-encoding-1.0.1-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.