Bug 1432068

Summary:	Review Request: perl-Proc-InvokeEditor - Perl extension for starting a text editor
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Proc-InvokeEditor-1.07-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-16 09:29:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1432106

Description Petr Pisar 2017-03-14 12:48:30 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Proc-InvokeEditor/perl-Proc-InvokeEditor.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Proc-InvokeEditor/perl-Proc-InvokeEditor-1.07-1.fc27.src.rpm
Description:
This Perl module provides the ability to supply some text to an external text
editor, have it edited by the user, and retrieve the results.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-15 12:28:11 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok

Tests failed
Couldn't find an editor: No such file or directory at /builddir/build/BUILD/Proc-InvokeEditor-1.07/blib/lib/Proc/InvokeEditor.pm line 178.
# Looks like your test exited with 2 just after 6.
t/02_editor.t ........
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/8 subtests

This part of code failed
./02_editor.t:35:my $f = Proc::InvokeEditor->first_usable;

FIX: Add at least one of default editors (vi, ed) to build-requires and
     also to run-requires.

Please correct 'FIX' issue and provide new spec file.

Comment 2 Petr Pisar 2017-03-15 14:51:42 UTC

Updated spec file is on the same address.

Comment 3 Jitka Plesnikova 2017-03-15 15:45:23 UTC

> Couldn't find an editor: No such file or directory at
> /builddir/build/BUILD/Proc-InvokeEditor-1.07/blib/lib/Proc/InvokeEditor.pm
> line 178.
> # Looks like your test exited with 2 just after 6.
> t/02_editor.t ........
> Dubious, test returned 2 (wstat 512, 0x200)
> Failed 2/8 subtests
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01_require.t ....... ok
t/02_editor.t ........ ok
t/03_pod.t ........... ok
t/04_pod_coverage.t .. ok
All tests successful.
Ok.

> FIX: Add at least one of default editors (vi, ed) to build-requires and
>      also to run-requires.
 # Tests:
+# ed || vi must be installed to pass tests
+BuildRequires:  ed

BuildRequires are ok

$ rpm -qp --requires perl-Proc-InvokeEditor-1.07-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Carp::Assert) >= 0.11
      1 perl(Exporter)
      1 perl(Fcntl)
      1 perl(File::Spec) >= 0.82
      1 perl(File::Temp) >= 0.12
      1 perl(IPC::Cmd)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Proc-InvokeEditor-1.07-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Proc::InvokeEditor) = 1.07
      1 perl-Proc-InvokeEditor = 1.07-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Proc-InvokeEditor*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 4 Gwyn Ciesla 2017-03-15 16:32:53 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Proc-InvokeEditor

Comment 5 Petr Pisar 2017-03-16 09:29:07 UTC

Thank you for the review and the editor.