Bug 1432082

Summary:	Review Request: perl-IO-Pager - Select a pager and pipe text to it if destination is a TTY
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	devrim, jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-IO-Pager-0.36-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-15 15:31:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1432106

Description Petr Pisar 2017-03-14 13:38:15 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-IO-Pager/perl-IO-Pager.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-IO-Pager/perl-IO-Pager-0.36-1.fc27.src.rpm
Description:
IO::Pager is used to locate an available pager and programmatically decide
whether or not to pipe a file handle's output to the pager.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-15 14:51:17 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-IO-Pager-0.36-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Env)
      1 perl(File::Spec)
      1 perl(File::Which)
      1 perl(IO::Handle)
      1 perl(IO::Pager)
      1 perl(POSIX)
      1 perl(PerlIO)
      1 perl(SelectSaver)
      1 perl(Symbol)
      1 perl(Tie::Handle)
      1 perl(base)
      1 perl(bytes)
      1 perl(overload)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-IO-Pager-0.36-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(IO::Pager) = 0.36
      1 perl(IO::Pager::Buffered) = 0.30
      1 perl(IO::Pager::Page) = 0.32
      1 perl(IO::Pager::Unbuffered) = 0.31
      1 perl-IO-Pager = 0.36-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-IO-Pager*
perl-IO-Pager.noarch: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
perl-IO-Pager.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

FIX: Please fix the typo 'licesne' in perl-IO-Pager.spec (line 5)

Please correct 'FIX' issue.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-15 15:13:00 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-IO-Pager

Comment 3 Petr Pisar 2017-03-15 15:31:59 UTC

Thank you for the review. I fixed the typo.

Comment 4 Petr Pisar 2017-03-15 15:32:08 UTC

*** Bug 1126045 has been marked as a duplicate of this bug. ***