Bug 1432106

Summary:	Review Request: perl-Reply - Plugin-based read-eval-print loop for Perl
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Reply-0.42-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-16 14:36:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1431742, 1432068, 1432082
Bug Blocks:

Description Petr Pisar 2017-03-14 14:22:49 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Reply/perl-Reply.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Reply/perl-Reply-0.42-1.fc27.src.rpm
Description:
Reply is a lightweight, extensible read-eval-print loop (REPL) for Perl. It is
plugin-based (see Reply::Plugin), and through plugins supports many advanced
features such as coloring and pretty printing, Readline support, and pluggable
commands.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-16 13:47:49 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Reply-0.42-1.fc27.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(App::Nopaste)
      1 perl(B::Keywords)
      1 perl(Carp::Always)
      1 perl(Class::Refresh) >= 0.05
      1 perl(Config::INI::Reader::Ordered)
      1 perl(Data::Dump)
      1 perl(Data::Dumper)
      1 perl(Data::Printer)
      1 perl(Eval::Closure) >= 0.11
      1 perl(Exporter)
      1 perl(File::HomeDir)
      1 perl(File::Spec)
      1 perl(Getopt::Long) >= 2.36
      1 perl(IO::Pager)
      1 perl(Module::Runtime)
      1 perl(Package::Stash)
      1 perl(PadWalker)
      1 perl(Proc::InvokeEditor)
      1 perl(Reply)
      1 perl(Reply::App)
      1 perl(Reply::Config)
      1 perl(Reply::Plugin)
      1 perl(Reply::Util)
      1 perl(Scalar::Util)
      1 perl(Term::ANSIColor)
      1 perl(Term::ReadKey)
      1 perl(Term::ReadLine)
      1 perl(Time::HiRes)
      1 perl(Try::Tiny)
      1 perl(base)
      1 perl(mro)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Reply-0.42-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Reply) = 0.42
      1 perl(Reply::App) = 0.42
      1 perl(Reply::Config) = 0.42
      1 perl(Reply::Plugin) = 0.42
      1 perl(Reply::Plugin::AutoRefresh) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Commands) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Functions) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Globals) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Keywords) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Lexicals) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Methods) = 0.42
      1 perl(Reply::Plugin::Autocomplete::Packages) = 0.42
      1 perl(Reply::Plugin::CollapseStack) = 0.42
      1 perl(Reply::Plugin::Colors) = 0.42
      1 perl(Reply::Plugin::DataDump) = 0.42
      1 perl(Reply::Plugin::DataDumper) = 0.42
      1 perl(Reply::Plugin::DataPrinter) = 0.42
      1 perl(Reply::Plugin::Defaults) = 0.42
      1 perl(Reply::Plugin::Editor) = 0.42
      1 perl(Reply::Plugin::FancyPrompt) = 0.42
      1 perl(Reply::Plugin::Hints) = 0.42
      1 perl(Reply::Plugin::Interrupt) = 0.42
      1 perl(Reply::Plugin::LexicalPersistence) = 0.42
      1 perl(Reply::Plugin::LoadClass) = 0.42
      1 perl(Reply::Plugin::Nopaste) = 0.42
      1 perl(Reply::Plugin::Packages) = 0.42
      1 perl(Reply::Plugin::Pager) = 0.42
      1 perl(Reply::Plugin::ReadLine) = 0.42
      1 perl(Reply::Plugin::ResultCache) = 0.42
      1 perl(Reply::Plugin::Timer) = 0.42
      1 perl(Reply::Util) = 0.42
      1 perl-Reply = 0.42-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Reply*
perl-Reply.noarch: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Reply.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-Reply.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
perl-Reply.src: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Reply.src: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-Reply.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-16 14:17:50 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Reply

Comment 3 Petr Pisar 2017-03-16 14:36:06 UTC

Thank you for the review and the repository.