Bug 1432372
| Summary: | packaged /usr/lib/.build-id break when %defattr used in spec | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | rpm | Assignee: | Packaging Maintenance Team <packaging-team-maint> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | atu.guda, crobinso, gryt2, ignatenko, kardos.lubos, mjw, mjw, mtasaka, packaging-team-maint, paul, randy, tmraz, vmukhame, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rpm-4.13.0.1-8.fc27 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-03-16 15:51:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1431296 | ||
|
Description
Remi Collet
2017-03-15 09:22:44 UTC
So the problem is that the directories in which the build-id files are placed conflict? That is indeed not the intention. Obviously this wasn't a problem when they were installed in the old location (under /usr/lib/debug/.build-id) so there is some difference in how the directories are added that causes this. I'll investigate. Diffing the package to try to understand how directories differ $ rpmdiff php-json-7.1.3-1.fc27.x86_64.rpm libselinux-2.6-3.fc27.x86_64.rpm | grep 'build-id$' .M....V..FT /usr/lib/.build-id I don't know what is "vflag" is but "mode" and "digest" could be an issue. $ ll -d php-json-7.1.3-1.fc27.x86_64/usr/lib/.build-id libselinux-2.6-3.fc27.x86_64/usr/lib/.build-id drwxr-xr-x. 4 remi remi 80 15 mars 11:02 libselinux-2.6-3.fc27.x86_64/usr/lib/.build-id drw-r--r--. 2 remi remi 40 15 mars 08:13 php-json-7.1.3-1.fc27.x86_64/usr/lib/.build-id We determined that this is caused by not resetting the defattr flags before adding the build-id dirs. So the bug triggers if the package file list has as last %defattr a non-default value. Working on a fix. Shouldn't /usr/lib/.build-id be part of filesystem? Even /usr/lib/.build-id/* probably should. Only /usr/lib/.build-id/*/* would be part of packages. This way we save two rpm "items" per package. Fix submitted upstream: http://lists.rpm.org/pipermail/rpm-maint/2017-March/005252.html And added to rpm-4.13.0.1-8.fc27. This should fix the issue when php has been rebuild against this new version. (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > Shouldn't /usr/lib/.build-id be part of filesystem? Even > /usr/lib/.build-id/* probably should. Only /usr/lib/.build-id/*/* would be > part of packages. This way we save two rpm "items" per package. I think this is a good suggestion, but not one I will try to fix with this bug. Sorry, I have rebuild PHP with unneeded %attr removed (in module sub-packages), thanks to your explanation, and everything is now ok. BTW great thanks for the explanation, the work, and the fix on this issue. (In reply to Remi Collet from comment #8) > Sorry, I have rebuild PHP with unneeded %attr removed (in module > sub-packages), thanks to your explanation, and everything is now ok. Thanks. That is fine of course. It shows we got the root cause correct. The upstream fix does contain a testcase based on the extra %attr setting that shows the same thing. *** Bug 1431896 has been marked as a duplicate of this bug. *** |