Bug 1432402

Summary: Installer didn't get correct router replica
Product: OpenShift Container Platform Reporter: Gaoyun Pei <gpei>
Component: InstallerAssignee: Andrew Butcher <abutcher>
Status: CLOSED ERRATA QA Contact: Gaoyun Pei <gpei>
Severity: high Docs Contact:
Priority: high    
Version: 3.5.0CC: abutcher, aos-bugs, jialiu, jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-11 21:19:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gaoyun Pei 2017-03-15 10:23:46 UTC
Description of problem:
During ocp-3.5 installation, although two nodes had the label matching router selector, but it still got "replicas": "1" when set_fact for router replicas.


Version-Release number of selected component (if applicable):
openshift-ansible-3.5.32-1.git.0.42cf266.el7.noarch.rpm

How reproducible:
Always

Steps to Reproduce:
1.Set openshift_hosted_router_selector in ansible inventory file and also have 2 nodes with corresponding node label specified.

[OSEv3:vars]
...

openshift_hosted_router_selector="role=node,router=enabled"


[nodes]
...

qe-gpei-ha-node-registry-router-1.0315-wqq.qe.rhcloud.com  openshift_hostname=qe-gpei-ha-node-registry-router-1 openshift_node_labels="{'role': 'node','registry': 'enabled','router': 'enabled'}"

qe-gpei-ha-node-registry-router-2.0315-wqq.qe.rhcloud.com  openshift_hostname=qe-gpei-ha-node-registry-router-2 openshift_node_labels="{'role': 'node','registry': 'enabled','router': 'enabled'}"



Actual results:
After installation, log into master to have a check
[root@qe-gpei-ha-master-etcd-1 ~]# oc get node --selector=role=node,router=enabled  -n default
NAME                                STATUS    AGE
qe-gpei-ha-node-registry-router-1   Ready     50m
qe-gpei-ha-node-registry-router-2   Ready     50m

[root@qe-gpei-ha-master-etcd-1 ~]# oc get pod |grep router
router-1-p1kgp             1/1       Running   0          45m

[root@qe-gpei-ha-master-etcd-1 ~]# oc get rc
NAME                 DESIRED   CURRENT   READY     AGE
docker-registry-1    2         2         2         30m
registry-console-1   1         1         1         30m
router-1             1         1         1         31m


Expected results:
router should have replicas=2

Additional info:

Comment 3 Gaoyun Pei 2017-03-20 07:59:34 UTC
Checked the code in openshift-ansible-3.5.37-1.git.0.62660e8.el7.noarch, related fix was not merged into openshift-ansible-3.5.37-1.git.0.62660e8.el7.noarch, wait for new openshift-ansible rpm package to verify this bug.

Comment 4 Scott Dodson 2017-03-20 14:29:35 UTC
https://github.com/openshift/openshift-ansible/pull/3696 merged in 3.5.38-1.git.0.fc961fd

Comment 5 Gaoyun Pei 2017-03-21 09:18:15 UTC
Verify this bug with openshift-ansible-3.5.39-1.git.0.cb12cdb.el7.noarch.rpm

Installer could get the correct router replica matching the node number of router selector.