Bug 1433451

Summary: Call to review: remove and Obsolete nss-devel subpackage and other minor spec file cleanups
Product: [Fedora] Fedora Reporter: Tomasz Kłoczko <kloczko.tomasz>
Component: glibcAssignee: Carlos O'Donell <codonell>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: arjun, codonell, dj, fweimer, law, mfabian, pfrankli, samuel-rhbugs, siddhesh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-31 15:12:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
glibc.spec patch none

Description Tomasz Kłoczko 2017-03-17 16:29:38 UTC 
Created attachment 1264210 [details]
glibc.spec patch

This ticket is call to review spec change before pushing it to git.

Copy of spec %changelog entry:

* Thu Mar 16 2017 Tomasz Kłoczko <kloczek> - 2.25.90-2
- remove nss-devel subpackage as libnss_*.so are not to shared libraries
  but loadable modules used by libc. These symlinks are not devel resources
- added glibc-nss-devel to main glibc Obsoletes list
- other minor cleanups:
-- remove Group and Buildroot fields (new packaging policy)
-- execute /sbin/ldconfig in %post/%postun of libcrypt and libcrypt-nss
   over -p switch causes that those packages will not have added
   "Requires(post): /bin/sh" and "Requires(postun): /bin/sh" and they will
   straight depends on /sbin/ldconfig
-- removed (as not needed) conditional %%if around subpackages preambles and
   %%post/%%postun scripts (%%if around %%files sections are enough)
-- removed %%clean script as rm -rf "$RPM_BUILD_ROOT" removes as well *.filelist*
   and currently default %%lean is executing "rm -rf $RPM_BUILD_ROOT"
-- move all %%post/%%postup under %%install

Ive promissed in https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/HNFIWUVULFIBUGIKUEIL5XR7K2MQMRDT/ that I'll submit nss-devel fix to review :)
Comment 1 Carlos O'Donell 2017-03-17 17:18:18 UTC 
Please submit your patch to Fedora glibc <glibc.org> for review by the package maintainers.

I think we can discuss things more easily by email than in the bugzilla and then link to the conclusion of the discussion.
Comment 2 Tomasz Kłoczko 2017-03-19 14:19:48 UTC 
Pitty that I must subscribe to yet-another-list to have such review ;>

OK. Will do this but within next few days because I found that I can improve few more things in glibc and on of those things may need a bit more testing before I should submit it.
Please do not close this ticket. Will back to it shortly :)
Comment 3 Tomasz Kłoczko 2017-07-31 15:12:25 UTC 
This ticket can be now closed.
Some still not commited parts are now in https://bugzilla.redhat.com/show_bug.cgi?id=1476839