Bug 1433571

Summary:	Undo pending xattrs only on the up bricks
Product:	[Community] GlusterFS	Reporter:	Karthik U S <ksubrahm>
Component:	replicate	Assignee:	Karthik U S <ksubrahm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ksubrahm, pkarampu, ravishankar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1436203 1436231 1437773 (view as bug list)		Environment:
Last Closed:	2017-05-30 18:47:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1436203, 1436231, 1437773

Description Karthik U S 2017-03-18 08:12:01 UTC

Description of problem:
While doing a conservative merge even if the brick is down the pending xattrs on that brick will be removed. This will lead to data loss situations. 


Version-Release number of selected component (if applicable):
mainline


How reproducible:
Always

Steps to Reproduce:
1. Create a 3 way replicated volume and set cluster.quorum-type to none
2. Bring bricks b1 & b2 down, and create file f1
3. Bring b3 down & b1 up, and create file f2
4. Bring b1 down & b2 up, and create file f3
5. Bring b3 up, shd will do the conservative merge and create f1 on b2 and f3 on  b3 and undo pending xattr on b1 as well
6. Bring b1 up. Now b1 blames b2 & b3. b2 & b3 does not blame b1. As part of the heal, b1 is considered as the source, and deletes f1 and f3 from both b2 & b3 leading to data loss

Actual results:
Pending xattrs are being reset for bricks which are down as well

Expected results:
Undo pending should reset the values of only the bricks which are up

Additional info:

Comment 1 Worker Ant 2017-03-18 08:23:19 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#1) for review on master by Karthik U S (ksubrahm)

Comment 2 Worker Ant 2017-03-19 13:17:56 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#2) for review on master by Karthik U S (ksubrahm)

Comment 3 Worker Ant 2017-03-20 06:13:06 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#3) for review on master by Karthik U S (ksubrahm)

Comment 4 Worker Ant 2017-03-20 12:19:35 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#4) for review on master by Karthik U S (ksubrahm)

Comment 5 Worker Ant 2017-03-27 04:27:03 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 6 Worker Ant 2017-03-27 04:52:42 UTC

REVIEW: https://review.gluster.org/16913 (cluster/afr: Undo pending xattrs only on the up bricks) posted (#6) for review on master by Karthik U S (ksubrahm)

Comment 7 Worker Ant 2017-03-27 09:52:34 UTC

COMMIT: https://review.gluster.org/16913 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit f91596e6566c605e70a31a60523d11f78a097c3c
Author: karthik-us <ksubrahm>
Date:   Sat Mar 18 13:44:56 2017 +0530

    cluster/afr: Undo pending xattrs only on the up bricks
    
    Problem:
    While doing conservative merge, even if a brick is down, it will reset
    the pending xattr on that. When that brick comes up, as part of the
    heal, it will consider this brick as the source and removes the entries
    on the other bricks, which leads to data loss.
    
    Fix:
    Undo pending only for the bricks which are up.
    
    Change-Id: I18436fa0bb1faa5f60531b357dea3f6b20446303
    BUG: 1433571
    Signed-off-by: karthik-us <ksubrahm>
    Reviewed-on: https://review.gluster.org/16913
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 8 Shyamsundar 2017-05-30 18:47:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/