Bug 1433650
| Summary: | python-pygments: nothing provides python2-pygments | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carl George <carlwgeorge> |
| Component: | python-pygments | Assignee: | Steve Milner <smilner> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | smilner |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-pygments-2.2.0-7.fc25 python-pygments-2.2.0-7.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-03-30 01:20:50 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Carl George
2017-03-19 01:08:59 UTC
Thanks for the report. I'll update the spec shortly and push to master. If you don't mind, I'd appreciate a review of the changes. Of course! Thanks for the quick response. Thanks Carl, The updated spec can be found at http://pkgs.fedoraproject.org/cgit/rpms/python-pygments.git/tree/. Seeing as EL5 goes EOL in 10 days, do you want to remove the python26 stuff?
There are a few fixes from the packaging guidelines I would recommend:
- The contents of the buildroot SHOULD NOT be removed in the first line of %install.
- The BuildRoot: tag, Group: tag, and %clean section SHOULD NOT be used.
- The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value
- Man page compression method may change, so use a wildcard pattern (%{_mandir}/man1/pygmentize.1*)
- Don't use the unversioned %{__python} and %{python_sitelib} macros (use %{__python2} and %{python2_sitelib} instead)
- Mark the LICENSE file as %license, not %doc
It looks like the docs are only built under Python 2, not Python 3. Is it beneficial to build them under both? Or should python3-sphinx be removed as a build requirement?
If you wrap the python3 things in 0%{?fedora} conditionals, the spec file can be merged back to the EPEL6/7 branches to ease future maintenance.
For better future compatibility, the Python 2 requirements can be specified with a conditional "2" to reference the exact Fedora package name.
BuildRequires: python%{?fedora:2}-setuptools
Good call. I'll drop the 26 stuff and will update the spec. Thanks for the review! I've been trying to rework this spec for a bit! Thanks for making those fixes, it looks much better now. Sorry to nitpick, just one last thing...
-%{python_sitelib}/*
+%{python2_sitelib}/*
Also, would you mind merging these fixes back to the f25 and f26 branches as well?
Updated and merged. Looks great! I'll be happy to add karma once the bodhi links come through. python-pygments-2.2.0-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3ceb94d98d python-pygments-2.2.0-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f70a3c4cc7 python-pygments-2.2.0-7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f70a3c4cc7 python-pygments-2.2.0-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3ceb94d98d python-pygments-2.2.0-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-pygments-2.2.0-7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |