Bug 1433760

Summary:	Review Request: python-cu2qu - Cubic-to-quadratic bezier curve conversion
Product:	[Fedora] Fedora	Reporter:	Athos Ribeiro <athoscribeiro>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-25 21:34:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1433623
Bug Blocks:

Description Athos Ribeiro 2017-03-19 21:16:30 UTC

Spec URL: https://athoscr.fedorapeople.org/packaging/python-cu2qu.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/python-cu2qu-1.1.1-1.fc25.src.rpm

Description: 
This library provides functions which take in UFO (Unified Font Object) objects
(Defcon Fonts or Robofab RFonts) and converts any cubic curves to quadratic.

Fedora Account System Username: athoscr

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-03-20 13:18:01 UTC

+ package name is OK
+ license is acceptable (ASL 2.0)
+ license is specified correctly
+ latest version
+ modern python packaging template is used
+ %python_provide are present
+ no scriptlets necessary
+ %check is present and passes
+ BR/R/P appear correct

Package is APPROVED.

With the license correction PR, I think you can say that the correction is trivial and non-copyrightable. It's pretty rich to require a CLA for a one-line change.

Comment 2 Athos Ribeiro 2017-03-20 14:54:22 UTC

Thanks for the review!

I followed your suggestion on the PR and also proposed closing the PR and letting them apply the change. It is fixed now [1].

[1] https://github.com/googlei18n/cu2qu/commit/9dbda1efa38df2c425438aa595e9ccc6f318a28c

Comment 3 Gwyn Ciesla 2017-03-20 15:02:53 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-cu2qu

Comment 4 Fedora Update System 2017-04-18 21:26:28 UTC

python-cu2qu-1.1.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ebcfdf0f75

Comment 5 Fedora Update System 2017-04-19 12:51:53 UTC

python-cu2qu-1.1.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ebcfdf0f75

Comment 6 Fedora Update System 2017-04-25 21:34:32 UTC

python-cu2qu-1.1.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.