Bug 1434341

Summary: FTBFS due missing zcrypt defines
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: opensshAssignee: Jakub Jelen <jjelen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jjelen, mattias.ellert, mgrepl, plautrba, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
Whiteboard:
Fixed In Version: openssh-7.5p1-2.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-01 17:20:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Dan Horák 2017-03-21 10:15:04 UTC
Build of latest openssh fails on s390x with

...
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -march=zEC12 -mtune=z13 -fvisibility=hidden -fPIC -I/usr/include/gssapi -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-strong  -I. -I. -I/usr/include/gssapi -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -I/usr/include/editline  -DLDAP_DEPRECATED    -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/libexec/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/libexec/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/libexec/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/libexec/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\" -DHAVE_CONFIG_H -c sandbox-seccomp-filter.c -o sandbox-seccomp-filter.o
In file included from sandbox-seccomp-filter.c:48:0:
sandbox-seccomp-filter.c:237:30: error: 'Z90STAT_STATUS_MASK' undeclared here (not in a function); did you mean 'AUDIT_STATUS_LOST'?
  SC_ALLOW_ARG(__NR_ioctl, 1, Z90STAT_STATUS_MASK),
                              ^
sandbox-seccomp-filter.c:237:2: note: in expansion of macro 'SC_ALLOW_ARG'
  SC_ALLOW_ARG(__NR_ioctl, 1, Z90STAT_STATUS_MASK),
  ^~~~~~~~~~~~
sandbox-seccomp-filter.c:238:30: error: 'ICARSAMODEXPO' undeclared here (not in a function)
  SC_ALLOW_ARG(__NR_ioctl, 1, ICARSAMODEXPO),
                              ^
sandbox-seccomp-filter.c:238:2: note: in expansion of macro 'SC_ALLOW_ARG'
  SC_ALLOW_ARG(__NR_ioctl, 1, ICARSAMODEXPO),
  ^~~~~~~~~~~~
sandbox-seccomp-filter.c:239:30: error: 'ICARSACRT' undeclared here (not in a function); did you mean 'SCM_SRCRT'?
  SC_ALLOW_ARG(__NR_ioctl, 1, ICARSACRT),
                              ^
sandbox-seccomp-filter.c:239:2: note: in expansion of macro 'SC_ALLOW_ARG'
  SC_ALLOW_ARG(__NR_ioctl, 1, ICARSACRT),
  ^~~~~~~~~~~~
make: *** [Makefile:160: sandbox-seccomp-filter.o] Error 1
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.sNnKeC (%build)
    Bad exit status from /var/tmp/rpm-tmp.sNnKeC (%build)
Child return code was: 1
EXCEPTION: [Error()]
...

For full logs please see https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2528871

The missing constants are defined in arch/s390/include/uapi/asm/zcrypt.h (kernel  userspace API headers, s390 specific).


Version-Release number of selected component (if applicable):
openssh-7.5p1-1.fc27

Comment 1 Jakub Jelen 2017-03-21 11:35:43 UTC
Thank you for the report. This was patch that upstream got from SUSE, but upstream didn't merge the header inclusion.

Already reported this on the upstream mailing list. I will send the new update soon with the appropriate header.

Comment 2 Fedora Update System 2017-03-23 20:41:57 UTC
openssh-7.5p1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ca197cf30

Comment 3 Fedora Update System 2017-03-23 20:42:06 UTC
openssh-7.5p1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ca197cf30

Comment 4 Dan Horák 2017-03-24 09:05:13 UTC
thanks, rawhide build is fixed in https://s390.koji.fedoraproject.org/koji/buildinfo?buildID=482039

Comment 5 Fedora Update System 2017-03-24 14:51:33 UTC
openssh-7.5p1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ca197cf30

Comment 6 Fedora Update System 2017-04-01 17:20:32 UTC
openssh-7.5p1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.