Bug 143445
| Summary: | xscreensaver-4.10-prune-hack-list.patch is bogus | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 3 | Reporter: | Jamie Zawinski <jwz> | ||||
| Component: | xscreensaver | Assignee: | Ray Strode [halfline] <rstrode> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 3.0 | CC: | panu.ervamaa | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-10-19 19:10:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Hi, I think the problem is that users are re-enabling it, not realizing that it could potentially render offensive/inappropriate content on their screens. As I understand it, this has caused more than a few people embarrassment in the workplace. The easiest solution to this problem was to remove the screensaver. That seemed like the best solution for RHEL3 and RHEL4 given time constraints. It doesn't seem like an unreasonable solution for Fedora either. How about if I changed the description in webcollage.xml to say "DANGER, THE INTERNET SOMETIMES CONTAINS PR0N" or something? Right now your patch both removes it entirely from the .ad file, and also doesn't install it. I think that there's no reason to do the latter (if it's not in the .ad file, it won't be in the list unless someone adds it to their ~/.xscreensaver file by hand.) e.g., --- config/webcollage.xml 26 Apr 2004 06:46:41 -0000 1.4 +++ config/webcollage.xml 4 Jan 2005 00:43:47 -0000 @@ -26,8 +26,12 @@ up to filter the images through the `VidWhacker' program, above, which looks really great. -(Note that most of the images it finds are text, and not pictures. -This is because most of the web is pictures of text. Which is pretty -sad.) Written by Jamie Zawinski. +WARNING: THE INTERNET SOMETIMES CONTAINS PORNOGRAPHY. + +The Internet being what it is, absolutely anything might show up in the +collage including -- quite possibly -- pornography, or even nudity. +Please act accordingly. + +Written by Jamie Zawinski. </_description> </screensaver> Created attachment 109326 [details]
xscreensaver-4.10-webcollage-warning.patch
This patch adds a "-disable" option to the webcollage executable, and a
corresponding checkbox at the configuration editor.
xscreensaver-4.10-webcollage-warning.patch makes xscreensaver-4.10-prune-hack-list.patch obsolete and should solve the original problem. This bug is filed against RHEL 3, which is in maintenance phase. During the maintenance phase, only security errata and select mission critical bug fixes will be released for enterprise products. Since this bug does not meet that criteria, it is now being closed. For more information of the RHEL errata support policy, please visit: http://www.redhat.com/security/updates/errata/ If you feel this bug is indeed mission critical, please contact your support representative. You may be asked to provide detailed information on how this bug is affecting you. |
This patch (included with xscreensaver-4.10-8.src.rpm from updates/enterprise/3desktop/) causes the "webcollage" and "webcollage-helper" programs to not be compiled or installed. This patch is wrong for two reasons: 1: when there is a program that you don't want people to be shown by default for some reason, you should just disable it in XScreenSaver.ad.in (you already do this for "bsod", for example.) 2: webcollage is *already* disabled by default, in both the upstream xscreensaver and in your copy of 4.10. All this patch does is make it impossible for people to run webcollage even if they know that they want to. I gather this is related to bug 130253, but I do not have permission to view that bug (why's that?)