Bug 1434454

Summary:	Existing MiqQueue rows can contain serialized Rails 4.2 era classes we can't deserialize in Rails 5+
Product:	Red Hat CloudForms Management Engine	Reporter:	Joe Rafaniello <jrafanie>
Component:	Appliance	Assignee:	Joe Rafaniello <jrafanie>
Status:	CLOSED ERRATA	QA Contact:	Dave Johnson <dajohnso>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	abellott, cpelland, jhardy, obarenbo, simaishi
Target Milestone:	GA
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.8.0.8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-31 14:43:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joe Rafaniello 2017-03-21 14:20:40 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible: Easy


Steps to Reproduce:
1.  Create a service retirement in a Rails 4.2 version of cfme, making sure it's on the miq_queue.
2.  Upgrade to a rails 5.0 version, such as cfme 5.7.x
3.  


Actual results:
Each MiqQueue deliver of these messages will fail with:
"undefined class/module ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Integer" attempting to get next message


Expected results:
The Worker should skip or mark this message as "error".


Additional info:

Comment 2 Joe Rafaniello 2017-03-21 14:21:56 UTC

Related to https://bugzilla.redhat.com/show_bug.cgi?id=1429747, which handles the issue by marking the bad queue message as "error".  This BZ will clear the bad rows from the miq_queue table.

Comment 3 CFME Bot 2017-03-21 14:31:47 UTC

https://github.com/ManageIQ/manageiq/pull/14418

Comment 4 CFME Bot 2017-03-22 18:26:14 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9795934bf9e5d42198278168d03d69fb26eebe73

commit 9795934bf9e5d42198278168d03d69fb26eebe73
Author:     Joe Rafaniello <jrafanie>
AuthorDate: Mon Mar 20 17:08:44 2017 -0400
Commit:     Joe Rafaniello <jrafanie>
CommitDate: Tue Mar 21 10:26:07 2017 -0400

    Remove MiqQueue rows containing a class removed in Rails 5.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434454
    
    The PostgreSQL::OID::Integer class was removed in:
    https://github.com/rails/rails/commit/aafee233fb3b4211ee0bfb1fca776c159bd1067e
    
    It's possible that old Rails 4.2 versions of objects could have been
    serialized in the MiqQueue in the args column and we won't be able to
    deserialize them with Rails 5+, so we need to remove these rows.
    
    Related to https://github.com/ManageIQ/manageiq/pull/14365
    Related to https://bugzilla.redhat.com/show_bug.cgi?id=1429747

 ...95659_remove_oid_integer_args_from_miq_queue.rb |  8 +++++++
 ..._remove_oid_integer_args_from_miq_queue_spec.rb | 27 ++++++++++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 db/migrate/20170320195659_remove_oid_integer_args_from_miq_queue.rb
 create mode 100644 spec/migrations/20170320195659_remove_oid_integer_args_from_miq_queue_spec.rb

Comment 5 Joe Rafaniello 2017-03-22 20:18:57 UTC

Note, this is not for backport to 5.7 because it's a data migration.  This is for 5.8+ only.

Comment 7 errata-xmlrpc 2017-05-31 14:43:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1367