Bug 1434573

Summary:	Add apache collectd plugin on engine machine
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	RFEs	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.0.0	CC:	bugs, juwu, lsvaty, pstehlik, ylavi
Target Milestone:	ovirt-4.1.1-1	Keywords:	FutureFeature
Target Release:	1.0.2	Flags:	rule-engine: ovirt-4.1+ rule-engine: exception+ ylavi: planning_ack+ rule-engine: devel_ack+ lsvaty: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-21 09:37:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1429875
Bug Blocks:	1402901, 1428386

Description Shirly Radco 2017-03-21 19:31:26 UTC

Description of problem:
We would like to be able to monitor the apache instance performance.
For that we require to add to the collectd configuration file the apache plugin.

Comment 1 Red Hat Bugzilla Rules Engine 2017-03-21 19:31:35 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Lukas Svaty 2017-03-30 09:14:23 UTC

this needs automatic population of the config values or proper documentation how to set them

TASK [ovirt_collectd/ovirt_engine : Place builtins-conf-for-ovirt-engine-config] ***
task path: /usr/share/ovirt-engine-metrics/setup/ansible/roles/ovirt_collectd/ovirt_engine/tasks/main.yml:2
fatal: [localhost]: FAILED! => {
    "changed": false, 
    "failed": true, 
    "invocation": {
        "module_args": {
            "dest": "/etc/collectd.d/20-builtins-conf-for-ovirt-engine.conf", 
            "src": "builtins-conf-for-ovirt-engine.conf.j2"
        }, 
        "module_name": "template"
    }, 
    "msg": "AnsibleUndefinedVariable: 'apache_instance' is undefined"
}

Comment 3 Red Hat Bugzilla Rules Engine 2017-03-30 09:14:27 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Shirly Radco 2017-04-04 08:37:43 UTC

I added a patch to add the apache plugin configuration, but not load it.
So it will not fail the collectd from starting.
Populating and loading the plugin will be don in bug 1429875.

Comment 5 Lukas Svaty 2017-04-07 11:30:23 UTC

doing sanity only as this does not add any new functionality

sanity were done that currently playbook runs successfully, and this does not break http of engine 

verified in ovirt-engine-metrics-1.0.2-1.el7ev.noarch

keep in mind all this does is add configuration for apache and does not install any additional rpm or anything else