Bug 1434712
| Summary: | [UPDATES] Fail to cancel update: The "pre-update" hook is not defined on SoftwareDeployment "UpdateDeployment" | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Yurii Prokulevych <yprokule> |
| Component: | openstack-tripleo-common | Assignee: | Julie Pichon <jpichon> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Alexander Chuzhoy <sasha> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 11.0 (Ocata) | CC: | augol, beth.white, brad, jcoufal, jrist, lbezdick, mburns, rbrady, rhel-osp-director-maint, sbaker, shardy, slinaber, srevivo |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | 11.0 (Ocata) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-tripleo-common-6.1.2-1.el7ost python-tripleoclient-6.2.0-2.el7ost | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-05 15:40:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1394025 | ||
|
Description
Yurii Prokulevych
2017-03-22 08:38:04 UTC
TBH we should probably remove the "cancel update" option from tripleo-client. There's no way to just stop an update in Heat. The stack-cancel-update command used by tripleo-client here *rolls back* an update, and it should *never* be used with TripleO because the TripleO templates are not designed in such a way as to leave the stack in a good state after a rollback. It doesn't make sense to have a UI that encourages users to do rollbacks. The error messages are probably caused by a timing improvement in Heat. I'm not totally sure why we were trying to clear the hooks at that point, but there's no correct way to implement this feature anyway. Starting with Newton Heat can now start a rollback of its in-progress nested stacks immediately when you start a rollback of the parent state. Previously I think the child stacks would keep updating? I can't remember the details. It's possible/likely that this rollback operation has become more destructive for TripleO now that Heat does it correctly. I agree, moving to UI team to remove this from our client commands given lacking support for update/upgrade rollback. We have RFEs for this feature in coming releases. *** Bug 1429342 has been marked as a duplicate of this bug. *** Ideally removed in OSP11 since it is not expected to be working. I will let UI/CLI team to decide whether it is blocker or not (I don't think so). Thanks to Brad, the command has been removed in Pike/OSP12. From what I can tell, it wouldn't be difficult to backport (v. minor conflicts in both patches) though there might be concerns about suddenly removing a command in existing releases without a deprecation period. However as indicated in comment 2 this likely never worked and has the potential for data loss, so it still sounds worthwhile doing. The two patches documented in the external tracker were backported to stable/ocata in https://review.openstack.org/#/c/481679/ and https://review.openstack.org/#/c/481679/ and already verified as part of bug 1427153. https://review.openstack.org/#/c/481679/3/tripleo_common/_stack_update.py clearly removes the "no=cancel update" option. Closing. |