Bug 143475
| Summary: | Missing expression in return statement | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | gnome-media | Assignee: | Alexander Larsson <alexl> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bnocera |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-02-02 10:11:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The upstream code still has that bug:
if (ioctl (cdrom->fd, CDROMREADTOCHDR, priv->tochdr) < 0) {
g_print ("Error reading CD header");
linux_cdrom_close (lcd);
return;
}
Fixed upstream in:
http://bugzilla.gnome.org/show_bug.cgi?id=403518
Thanks for the notice.
|
Description of problem: I just tried to compile package gnome-media-2.8.0-4 from Redhat Fedora development tree. The compiler said linux-cdrom.c(868): warning #117: non-void function "linux_cdrom_get_status" should return a value The source code is return; But static gboolean linux_cdrom_get_status (GnomeCDRom *cdrom, GnomeCDRomStatus **status, GError **error) { Suggest add expression to return statement. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: