Bug 1434849

Summary: Tempest does not properly initialize the configuration values from tempest.conf for some plugins
Product: Red Hat OpenStack Reporter: Chandan Kumar <chkumar>
Component: openstack-tempestAssignee: Chandan Kumar <chkumar>
Status: CLOSED ERRATA QA Contact: Luigi Toscano <ltoscano>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 10.0 (Newton)CC: apevec, jjoyce, lhh, ltoscano, mcornea, mkopec, slinaber, yprokule
Target Milestone: z3Keywords: Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tempest-13.0.0-12.bafe630git.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1432919 Environment:
Last Closed: 2017-06-28 15:29:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1432919    
Bug Blocks:    

Description Chandan Kumar 2017-03-22 13:20:46 UTC 
+++ This bug was initially created as a clone of Bug #1432919 +++

Description of problem:

When tempest initialize the configuration of the plugins, it performs some magic with the global CONF object. Until some recent fixes (post-15.0), the magic was wrong and the values from tempest.conf related to some Tempest plugins using ServiceClients in some conditions (i.e. referring CONF in the plugin initialization) where not set.

This is visible in the Sahara Tempest plugin, which references the CONF object in the plugin initialization. This lead to an wrong nested call in the initialization phase for that object, and the final result is that the values in the data-processing section of tempest.conf are ignored.

Result: if for example endpoint list does not match (as it happens for v3) the default value (publicURL), the endpoint_type option for Sahara is ignored, tempest picks a random endpoint which ends up being the wrong one and the connection does not work.
The Sahara plugin is specifically affected because it was one of the few that migrated to the new manager interface (based on ServiceClients) AND its configuration section in tempest.conf has a dash, which lead to some specific code to handle it in the Sahara plugin (wrongly) which triggered the issue.

The fix for this (i.e. properly initialize the CONF object for tempest plugins) was fixed in Tempest in the following commits:

http://git.openstack.org/cgit/openstack/tempest/commit/?id=8b23c79325ed68c6741683690c69ba3f64acfc2e
http://git.openstack.org/cgit/openstack/tempest/commit/?id=382a6f12a38baab47918fb902ccfd9e451c04800



There are some other cleanup in the Sahara plugin but the commit above seems to  be enough. They should either backported to the package, or the package could be bumped to a git snapshot (I think a new tag of Tempest will be created when Mitaka is EOL).

Version-Release number of selected component (if applicable):
openstack-tempest-15.0.0-1.el7ost.noarch
Comment 1 Red Hat Bugzilla Rules Engine 2017-03-22 13:20:56 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 2 Red Hat Bugzilla Rules Engine 2017-03-22 13:46:55 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 5 Luigi Toscano 2017-05-30 16:33:26 UTC 
As in the original bug, after backporting the fixes,  when using the Sahara Tempest plugin no failures have been observed in a good amount of deployment/test  runs  (i.e. the value of the endpoint is picked correctly and the test can be executed). This is consistent with the expected behavior after backporting the patches mentioned above.

Verified on:
openstack-tempest-13.0.0-12.bafe630git.el7ost.noarch
python-sahara-tests-tempest-0.4.1-1.el7ost.noarch
python-tempest-13.0.0-12.bafe630git.el7ost.noarch
Comment 7 errata-xmlrpc 2017-06-28 15:29:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1587