Bug 1434868

Summary:	Fence agents should be dropped from VDS view join
Product:	[oVirt] ovirt-engine	Reporter:	Yevgeny Zaspitsky <yzaspits>
Component:	Database.DAL	Assignee:	Eli Mesika <emesika>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Petr Matyáš <pmatyas>
Severity:	medium	Docs Contact:
Priority:	low
Version:	future	CC:	bugs, lsvaty, mgoldboi, mperina, oourfali
Target Milestone:	ovirt-4.2.0	Keywords:	Improvement
Target Release:	---	Flags:	rule-engine: ovirt-4.2+ lsvaty: testing_plan_complete-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:45:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yevgeny Zaspitsky 2017-03-22 14:03:36 UTC

Description of problem:
Fence agents should be dropped from VDS view join. 

In case of more then 1 fence agent is defined for a single host the view returns the same host rows as many times as many agents are defined. That is bug prone for the view user.
Beside that it has some performance impact on the queries related to VDS view. 

Version-Release number of selected component (if applicable):
Exists since 3.6 in code, should be dropped since 4.0.

How reproducible:
100%

Steps to Reproduce:
1. Add a host
2. Add 2 fence agents to the host
3. Query vds view for the host by name/id or any other unique field.

Actual results:
Select from vds view returns 2 rows for the new host.

Expected results:
A single row is reported for any single host by vds view.

Additional info:
According to Ori Liel (feature owner), that exists there for backward compatibility reason, is deprecated in REST API and could've being dropped since 4.0.

Comment 1 Martin Perina 2017-03-23 08:24:20 UTC

Targeting to 4.2, because we are going to drop APIv3 support, so we can drop deprecated no longer needed code and also perform better optimizations.

Comment 2 Oved Ourfali 2017-07-04 07:44:57 UTC

v3 will not be removed in 4.2, so moving to 4.3.

Comment 3 Yaniv Kaul 2017-10-29 11:24:57 UTC

(In reply to Oved Ourfali from comment #2)
> v3 will not be removed in 4.2, so moving to 4.3.

But the code is now merged into master?

Comment 4 Oved Ourfali 2017-10-29 11:27:31 UTC

(In reply to Yaniv Kaul from comment #3)
> (In reply to Oved Ourfali from comment #2)
> > v3 will not be removed in 4.2, so moving to 4.3.
> 
> But the code is now merged into master?

As far as I remember it caused a regression. Not sure whether eventually it was brought back at any way.

Martin?

Comment 5 Eli Mesika 2017-10-29 12:11:17 UTC

(In reply to Oved Ourfali from comment #4)
> (In reply to Yaniv Kaul from comment #3)
> > (In reply to Oved Ourfali from comment #2)
> > > v3 will not be removed in 4.2, so moving to 4.3.
> > 
> > But the code is now merged into master?
> 
> As far as I remember it caused a regression. Not sure whether eventually it
> was brought back at any way.
> 
> Martin?

It caused several regressions , were fixed and merged :

https://gerrit.ovirt.org/#/c/83036/
https://gerrit.ovirt.org/#/c/83037/
https://gerrit.ovirt.org/#/c/83038/
https://gerrit.ovirt.org/#/c/83039/

Comment 6 Petr Matyáš 2017-10-31 08:55:07 UTC

Verified on ovirt-engine-4.2.0-0.0.master.20171030093856.gitc4dc9af.el7.centos.noarch

Comment 7 Sandro Bonazzola 2017-12-20 11:45:44 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.