Bug 1434879

Summary: Container volumes should honour tag visibility
Product: Red Hat CloudForms Management Engine Reporter: Dafna Ron <dron>
Component: UI - OPSAssignee: Dan Clarizio <dclarizi>
Status: CLOSED CURRENTRELEASE QA Contact: Einat Pacifici <epacific>
Severity: high Docs Contact:
Priority: medium    
Version: 5.8.0CC: dron, fsimonce, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: container
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1445086 (view as bug list) Environment:
Last Closed: 2018-03-06 14:37:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Container Management Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1445086    
Attachments:
Description Flags
logs and screenshots none

Description Dafna Ron 2017-03-22 14:33:07 UTC
Created attachment 1265412 [details]
logs and screenshots

Description of problem:

I set a location tag but the user can see all volumes. 

Version-Release number of selected component (if applicable):

cfme-5.8.0.7-1.el7cf.x86_64
I am using a cfme podfied version with remote nfs server for the volumes 

How reproducible:

100%

Steps to Reproduce:
1. deploy podfied cfme on openshift and attach the openshift 3.4 as a provider under the cfme pod
2. log in as admin -> configuration -> access control -> create a new role -> create a new group with a location tag for NY -> create a new user and add the group to the user. 
3. log in as the user 

Actual results:
since none of the objects were tagged to be on location NY you should not see any objects 

Expected results:

we see all container volumes 

Additional info:
screenshot and logs

Comment 2 Federico Simoncelli 2017-03-22 20:53:46 UTC
Dafna I see that you reported this as a regression but I have the feeling this bug was present in 5.7.
Can you try and reproduce there? In case it reproduces we'll ask a clone for 5.7 as well.

Comment 3 Dafna Ron 2017-03-23 13:07:37 UTC
you're right. I checked lastest 5.7 and 5.7.0.17 and it was in both versions. 
was there already a bug opened that has not been fixed yet?

Comment 4 Federico Simoncelli 2017-03-24 09:22:19 UTC
(In reply to Dafna Ron from comment #3)
> you're right. I checked lastest 5.7 and 5.7.0.17 and it was in both
> versions. 
> was there already a bug opened that has not been fixed yet?

No, I guessed it by looking at the code history.

Zahi, please let's make sure that we don't have this issue in other pages (and let's add tests).

Comment 5 zakiva 2017-03-27 11:28:26 UTC
Upstream PRs:
Manageiq: https://github.com/ManageIQ/manageiq/pull/14517
Manageiq-ui-classic: https://github.com/ManageIQ/manageiq-ui-classic/pull/808

Comment 7 Einat Pacifici 2017-11-12 13:23:39 UTC
Verified. Followed instructions on Description, new user with defined role, cannot see any of the objects for the attached provider.