Bug 1435113

Summary: Missing style for the flash message in expression editor
Product: Red Hat CloudForms Management Engine Reporter: Dmitry Misharov <dmisharo>
Component: UI - OPSAssignee: Jozef Zigmund <jzigmund>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: low Docs Contact:
Priority: low    
Version: 5.8.0CC: cpelland, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: ui:condition
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1440317 (view as bug list) Environment:
Last Closed: 2018-03-06 14:49:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1440317    
Attachments:
Description Flags
Screenshot of the bug
none
Message for Scope none

Description Dmitry Misharov 2017-03-23 08:06:57 UTC
Created attachment 1265634 [details]
Screenshot of the bug

Description of problem:
Flash message in condition expression editor missing style, it's just plain text.

Version-Release number of selected component (if applicable):
5.8.0.7.20170321164727_1c97ccd 

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Control/Explorer.
2. Expand Conditions accordion.
3. Open condtion creation screen.
4. Switch to scope editing.

Actual results:
Flash message "No expression defined, a condition must contain a valid expression. " missing styles.

Expected results:
Flash message should have shadow background and borders.

Comment 3 Dmitry Misharov 2017-03-23 14:59:08 UTC
Created attachment 1265814 [details]
Message for Scope

Harpreet please consider attached screenshot, how that message looks for Scope.

Comment 4 Harpreet Kataria 2017-03-23 20:48:43 UTC
Jozef,

Can you take a look and fix the message to be an informational message, similar to the one in Scope area. Let me know if you need help or have any questions.

Thanks,
~Harpreet

Comment 6 CFME Bot 2017-04-07 09:18:22 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/63ead17e8c57616ce28c1d92289691ecf5a8b360

commit 63ead17e8c57616ce28c1d92289691ecf5a8b360
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Thu Apr 6 13:01:23 2017 +0200
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Thu Apr 6 13:01:35 2017 +0200

    Changed text to flash message
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1435113

 app/views/miq_policy/_form_expression.html.haml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 8 Dmitry Misharov 2017-10-17 11:53:33 UTC
Verified in 5.9.0.2.20171010190026_0413a06.