Bug 1435232

Summary:	Review Request: perl-Devel-SimpleTrace - See where you code warns and dies using stack traces
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Devel-SimpleTrace-0.08-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-24 13:01:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1435295

Description Petr Pisar 2017-03-23 12:29:17 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Devel-SimpleTrace/perl-Devel-SimpleTrace.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Devel-SimpleTrace/perl-Devel-SimpleTrace-0.08-1.fc27.src.rpm
Description:
This Perl module can be used to more easily spot the place where a program or a
module generates errors.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-24 09:47:57 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Devel-SimpleTrace-0.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Data::Dumper)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Devel-SimpleTrace-0.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Devel::SimpleTrace) = 0.08
      1 perl-Devel-SimpleTrace = 0.08-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Devel-SimpleTrace*
perl-Devel-SimpleTrace.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Devel-SimpleTrace/LICENSE.GPL
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
NOTE: The incorrect address was reported to upstream
Rpmlint is ok.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-24 12:11:38 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Devel-SimpleTrace

Comment 3 Petr Pisar 2017-03-24 13:01:38 UTC

Thank you for the review and the repository.